Solution #409
Open
Solution #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denys-source
commented
Sep 25, 2023
denys-source
commented
Barsh4ec
approved these changes
Sep 25, 2023
Serhii-Leonenko
suggested changes
Sep 27, 2023
Comment on lines
+64
to
+67
| def get_context_data(self, **kwargs: Any) -> dict[str, Any]: | ||
| context = super().get_context_data(**kwargs) | ||
| context["car_list"] = self.object.cars.select_related("manufacturer") | ||
| return context |
There was a problem hiding this comment.
For what purpose did you use this method instead of queryset optimization
There was a problem hiding this comment.
I thought that Driver.objects.prefetch_related("cars__manufacturer") will cache related cars and corresponding manufacturers for every driver, but we need to cache related cars for only one driver. I tested these two approaches and the current one is faster:
.prefetch_related("cars__manufacturer"):
current one:
Serhii-Leonenko
suggested changes
Sep 28, 2023
taxi/views.py
Outdated
| @@ -94,15 +91,13 @@ class ManufacturerCreateView(LoginRequiredMixin, CreateView): | |||
| model = Manufacturer | |||
| fields = "__all__" | |||
| success_url = reverse_lazy("taxi:manufacturer-list") | |||
| template_name = "taxi/manufacturer_form.html" | |||
| context_object_name = "manufacturer" | |||
There was a problem hiding this comment.
context_object name is also redundant attribute
Serhii-Leonenko
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.