py-taxi-service-forms #412
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaroslav-mazurkevych
commented
Sep 26, 2023
yaroslav-mazurkevych
commented
OstapIvakh
approved these changes
Sep 26, 2023
Sofbog
suggested changes
Sep 28, 2023
taxi/views.py
Outdated
| model = Car | ||
| fields = "__all__" | ||
| success_url = reverse_lazy("taxi:car-list") | ||
| template_name = "taxi/car_form.html" |
There was a problem hiding this comment.
do we really need template_name , fix it all over the code
There was a problem hiding this comment.
still not fixed...
Fix everywhere
|
|
||
| <form action="" method="post"> | ||
| {% csrf_token %} | ||
| <input type="submit" value="Yes, delete" class="btn btn-danger" /> |
There was a problem hiding this comment.
it will be a good option for the user to cancel deletion , that’s why we have an extra step before deleting something
templates/taxi/car_update_form.html
Outdated
| {{ form|crispy }} | ||
| <input class="btn btn-primary" type="submit" value="Submit"> | ||
| </form> | ||
| {% endblock %} |
There was a problem hiding this comment.
Add a newline at the end of the all files where it missing
There was a problem hiding this comment.
still no blank line at the end of several files
Serhii-Leonenko
suggested changes
Oct 2, 2023
taxi/views.py
Outdated
| model = Car | ||
| fields = "__all__" | ||
| success_url = reverse_lazy("taxi:car-list") | ||
| template_name = "taxi/car_form.html" |
There was a problem hiding this comment.
still not fixed...
Fix everywhere
templates/taxi/car_update_form.html
Outdated
| {{ form|crispy }} | ||
| <input class="btn btn-primary" type="submit" value="Submit"> | ||
| </form> | ||
| {% endblock %} |
There was a problem hiding this comment.
still no blank line at the end of several files
Delete template names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.