Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution #413

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Solution #413

wants to merge 3 commits into from

Conversation

ZaichenkoViktoriia
Copy link

0 1 2 3 4 5 6 7

ORENYT
ORENYT approved these changes Sep 26, 2023
View reviewed changes
Copy link

@ORENYT ORENYT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

Serhii-Leonenko
Serhii-Leonenko suggested changes Sep 28, 2023
View reviewed changes
taxi/views.py Outdated
model = Car
fields = "__all__"
success_url = reverse_lazy("taxi:car-list")
template_name = "taxi/car_form.html"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this template name is redundant because you use the default name. Fix everywhere

Sofbog
Sofbog approved these changes Sep 29, 2023
View reviewed changes
Copy link

@Sofbog Sofbog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ORENYT ORENYT ORENYT approved these changes

@Sofbog Sofbog Sofbog approved these changes

@Serhii-Leonenko Serhii-Leonenko Awaiting requested review from Serhii-Leonenko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ZaichenkoViktoriia @Sofbog @Serhii-Leonenko @ORENYT