Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #419

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Develop #419

wants to merge 4 commits into from

Conversation

sashabryl
Copy link

Знімок екрана 2023-09-27 182902
Знімок екрана 2023-09-27 182920
Знімок екрана 2023-09-27 182927
Знімок екрана 2023-09-27 182939
Знімок екрана 2023-09-27 182947
Знімок екрана 2023-09-27 182959
Знімок екрана 2023-09-27 183019
Знімок екрана 2023-09-27 183029
Знімок екрана 2023-09-27 183044
Знімок екрана 2023-09-27 183057

Dimosphen1
Dimosphen1 approved these changes Sep 27, 2023
View reviewed changes
Copy link

@Dimosphen1 Dimosphen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, well done! One comment is left for consideration.

taxi/views.py
@@ -52,3 +54,43 @@ class DriverListView(LoginRequiredMixin, generic.ListView):
class DriverDetailView(LoginRequiredMixin, generic.DetailView):
model = Driver
queryset = Driver.objects.all().prefetch_related("cars__manufacturer")


class CarCreateView(generic.CreateView, LoginRequiredMixin):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixins are usually placed in a first position, consider it in your future classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dimosphen1 Dimosphen1 Dimosphen1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sashabryl @Dimosphen1