Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution #449

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Solution #449

wants to merge 7 commits into from

Conversation

vshvanska
Copy link

Cars:
car_list
Car detail:
car_detail
Create car:
car_create
Update car:
car_update
Manufacters:
manufacturer_list
Delete manufacter:
delete_manufacturer
Create manufacter:
manufacturer_create
Update manufacturer:
update_manufacturer

@Naz-iv
Copy link

Naz-iv commented Nov 16, 2023

As per checklist, we should add cancel button to your delete page
image

Naz-iv
Naz-iv suggested changes Nov 16, 2023
View reviewed changes
Copy link

@Naz-iv Naz-iv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add cansel button

@vshvanska
Copy link
Author

Cars: car_list Car detail: car_detail Create car: car_create Update car: car_update Manufacters: manufacturer_list Create manufacter: manufacturer_create Update manufacturer: update_manufacturer
manufacturer_delete

car_delete

LiudmylaKulinchenko
LiudmylaKulinchenko suggested changes Nov 20, 2023
View reviewed changes
taxi/views.py Outdated

class ManufacturerDeleteView(LoginRequiredMixin, generic.DeleteView):
model = Manufacturer
fields = "__all__"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's no need to add fields = "__all__" in delete view

LiudmylaKulinchenko
LiudmylaKulinchenko approved these changes Nov 20, 2023
View reviewed changes
Copy link

@LiudmylaKulinchenko LiudmylaKulinchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 🦋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naz-iv Naz-iv Naz-iv requested changes

@LiudmylaKulinchenko LiudmylaKulinchenko LiudmylaKulinchenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vshvanska @Naz-iv @LiudmylaKulinchenko