Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution #457

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Solution #457

wants to merge 5 commits into from

Conversation

Shatrovskyi
Copy link

@Shatrovskyi Shatrovskyi commented Nov 17, 2023 •
edited
Loading

2
3
4
5
6
7
8
9
10
17

LiudmylaKulinchenko
LiudmylaKulinchenko suggested changes Nov 20, 2023
View reviewed changes
Copy link

@LiudmylaKulinchenko LiudmylaKulinchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Cancel button apart from Delete one. The Cancel button will lead to the previous page the user was on -- checklist

taxi/views.py Outdated
model = Car
fields = "__all__"
success_url = reverse_lazy("taxi:car-list")
template_name = "taxi/car_form.html"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't override template_name, context_object_name and so on if they are the same as default ones -- checklist

@Shatrovskyi
Copy link
Author

11
12

LiudmylaKulinchenko
LiudmylaKulinchenko approved these changes Nov 21, 2023
View reviewed changes
Copy link

@LiudmylaKulinchenko LiudmylaKulinchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 🎈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katyakoziar katyakoziar katyakoziar approved these changes

@LiudmylaKulinchenko LiudmylaKulinchenko LiudmylaKulinchenko approved these changes

@Lyutillis Lyutillis Lyutillis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Shatrovskyi @Lyutillis @LiudmylaKulinchenko @katyakoziar