Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
taxi form solution #870
base: master
Are you sure you want to change the base?
taxi form solution #870
Changes from 1 commit
3eef499
f87d7da
9363b6f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a trailing slash to the 'create' path for manufacturers to align with Django's URL conventions and maintain consistency with the car paths.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a trailing slash to the 'update' path for manufacturers to align with Django's URL conventions and maintain consistency with the car paths.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a trailing slash to the 'delete' path for manufacturers to align with Django's URL conventions and maintain consistency with the car paths.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Critical Issue: The
action
attribute of the form is empty. Ensure it points to the correct URL where the delete action should be processed. You can use Django's URL template tag to dynamically generate the correct URL.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Critical Issue: The method
car.drivers.all
should be called with parentheses:car.drivers.all()
. This is necessary to execute the method and retrieve the list of drivers.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Critical Issue: The
action
attribute of the form is empty. Ensure it points to the correct URL where the form data should be submitted. You can use Django's URL template tag to dynamically generate the correct URL.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Critical Issue: The
action
attribute of the form is empty. Ensure it points to the correct URL where the delete action should be processed. You can use Django's URL template tag to dynamically generate the correct URL.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Critical Issue: The
action
attribute of the form is empty. Ensure it points to the correct URL where the form data should be submitted. You can use Django's URL template tag to dynamically generate the correct URL.