Fix validate_seat_and_row error handling, update action comparison in…

… views, and add pagination settings
mate-academy · Jan 6, 2025 · 9385d07 · 9385d07
1 parent b9df023
commit 9385d07
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/cinema/models.py b/cinema/models.py
@@ -89,7 +89,7 @@ def validate_seat_and_row(
             row: int,
             seat: int,
             movie_session,
-            error_to_raise
+            error_to_raise=ValidationError
     ):
         cinema_hall = movie_session.cinema_hall
 

diff --git a/cinema/serializers.py b/cinema/serializers.py
@@ -131,6 +131,7 @@ def validate(self, attrs):
         return data
 
 
+
 class TicketDetailSerializer(serializers.ModelSerializer):
     movie_session = MovieSessionListSerializer(read_only=True)
 

diff --git a/cinema/views.py b/cinema/views.py
@@ -56,7 +56,7 @@ def get_queryset(self):
         if title:
             queryset = queryset.filter(title__icontains=title)
 
-        if self.action == ("list", "retrieve"):
+        if self.action == ["list", "retrieve"]:
             queryset = Movie.objects.prefetch_related("actors")
 
         return queryset.distinct()

diff --git a/cinema_service/settings.py b/cinema_service/settings.py
@@ -128,6 +128,11 @@
 
 # USE_TZ = False
 
+# REST_FRAMEWORK = {
+#    "DEFAULT_PAGINATION_CLASS": "rest_framework.pagination.LimitOffsetPagination",
+#    "PAGE_SIZE": 1
+# }
+
 # Static files (CSS, JavaScript, Images)
 # https://docs.djangoproject.com/en/4.0/howto/static-files/
Original file line number	Diff line number	Diff line change
Expand Up		@@ -131,6 +131,7 @@ def validate(self, attrs):
		return data



		class TicketDetailSerializer(serializers.ModelSerializer):
		movie_session = MovieSessionListSerializer(read_only=True)

Expand Down