Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution #729

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Solution #729

wants to merge 2 commits into from

Conversation

yulia-pl
Copy link

No description provided.

Mxbely
Mxbely suggested changes Dec 13, 2024
View reviewed changes
Copy link

@Mxbely Mxbely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not need rewrite default models and tests, you have a lot of unuseful changes, you have the same solution in Mates videos

cinema/models.py
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't need rewrite default models

cinema/tests/test_actor_api.py
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you refactor tests?

@yulia-pl yulia-pl requested a review from Mxbely December 20, 2024 13:01
mateacademy-ai-mentor
mateacademy-ai-mentor approved these changes Dec 20, 2024
View reviewed changes
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on your submission! 🎉 Your code meets the core requirements and is well-structured, with comprehensive test coverage and adherence to Django and DRF conventions. While there are a few minor improvements suggested, such as ensuring no database files are pushed to the repository and enhancing code style, these do not impact the functionality. Keep up the excellent work, and consider the feedback for future enhancements! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateacademy-ai-mentor mateacademy-ai-mentor mateacademy-ai-mentor approved these changes

@Mxbely Mxbely Awaiting requested review from Mxbely

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yulia-pl @Mxbely @mateacademy-ai-mentor