Solution #740
Solution #740
Conversation
There was a problem hiding this comment.
Great job on implementing the cinema application! 🎬 While there are a few minor issues, such as the error handling in MovieSessionViewSet and the create method in OrderSerializer, these do not significantly impact the functionality. Keep up the good work and consider the feedback for future improvements! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
|
|
||
|
|
||
| class OrderSerializer(serializers.ModelSerializer): | ||
| tickets = TicketSerializer(many=True, read_only=False, allow_empty=False) |
There was a problem hiding this comment.
In the OrderSerializer, the tickets field is set with read_only=False and allow_empty=False. Ensure that the create method properly validates the ticket data before creating Ticket instances to prevent potential data integrity issues.
| return Response( | ||
| {"error": "Invalid date format. Please use YYYY-MM-DD."}, | ||
| status=status.HTTP_400_BAD_REQUEST | ||
| ) |
There was a problem hiding this comment.
In the MovieSessionViewSet, returning a Response object directly from get_queryset is not standard practice. Instead, consider raising a serializers.ValidationError or handling the error in a different method to maintain consistency with the rest of the viewset.
| return Response( | ||
| {"error": "Invalid movie ID. Please provide an integer."}, | ||
| status=status.HTTP_400_BAD_REQUEST | ||
| ) |
There was a problem hiding this comment.
Similar to the previous comment, returning a Response object directly from get_queryset is not standard. Consider raising a serializers.ValidationError or handling the error in a different method to ensure consistency.
No description provided.