Solution #741
Solution #741
Conversation
There was a problem hiding this comment.
Great job on implementing the task requirements! 🎉 Your code meets the core functionality and aligns well with Django REST Framework practices. There are a few minor improvements suggested, such as ensuring no database files are pushed to the repository and refining the condition for checking actions in viewsets. Keep up the good work, and consider these suggestions for future enhancements. Well done! 👏
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| if self.action == "retrieve": | ||
| return MovieDetailSerializer | ||
|
|
||
| return MovieSerializer | ||
|
|
||
| def get_queryset(self): | ||
| queryset = super().get_queryset() | ||
| if self.action == ("list", "retrieve"): |
There was a problem hiding this comment.
The condition if self.action == ("list", "retrieve"): is incorrect. The self.action attribute is a string, so it should be compared to a single string value, not a tuple. Consider using if self.action in ["list", "retrieve"]: to check if the action is either 'list' or 'retrieve'.
No description provided.