Develop #744
Develop #744
Conversation
…ers that filtered by the authenticated user. Add detail information about movie session
…t forget to place config in the settings.py.
…filtered by the authenticated user. Add detail information about movie session and implement pagination. Note, to implement pagination don't forget to place config in the settings.py.
…ated user. It should support the following request structure:
…=, ?genres= and ?title= parameters. Filtering by title with the string parameter should return all movies whose title contains string.
…ould be provided in year-month-day format, the movie by its id.
…ys about how many tickets are still available for each movie_session
There was a problem hiding this comment.
Great job on implementing the API endpoints and ensuring robust functionality! 🎉 While there are a few minor issues, such as pagination not being applied to the OrdersViewSet and some code style improvements, these do not critically impact the functionality. Consider addressing these in future iterations for enhanced code quality. Keep up the excellent work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| model_name='movie', | ||
| name='duration', | ||
| model_name="movie", | ||
| name="duration", | ||
| field=models.IntegerField(default=123), |
There was a problem hiding this comment.
The default value is set to 123, but preserve_default is set to False. This means that the default value will not be preserved for existing rows in the database. If you intend to apply this default value to existing records, consider setting preserve_default to True or handling existing records separately.
| model_name='genre', | ||
| name='name', | ||
| model_name="genre", | ||
| name="name", | ||
| field=models.CharField(max_length=255, unique=True), |
There was a problem hiding this comment.
Setting the name field to unique=True means that all existing and future entries must have unique values for this field. Ensure that there are no duplicate name values in the existing database records, as this will cause the migration to fail.
| f"{str(self.movie_session)} (row: {self.row}, seat: {self.seat})" | ||
| ) | ||
| return (f"{str(self.movie_session)}" | ||
| f" (row: {self.row}, seat: {self.seat})") | ||
|
|
||
| class Meta: | ||
| unique_together = ("movie_session", "row", "seat") |
There was a problem hiding this comment.
The unique_together constraint ensures that each combination of movie_session, row, and seat is unique. This is important for preventing duplicate tickets for the same seat in a session. Ensure that this constraint is properly enforced in your database schema.
|
|
||
|
|
||
| class OrderSerializer(serializers.ModelSerializer): | ||
| tickets = TicketSerializer(many=True, allow_empty=False) |
There was a problem hiding this comment.
The allow_empty=False parameter in the tickets field ensures that an order cannot be created without tickets. This is a good validation step to prevent empty orders.
| tickets_data = validated_data.pop("tickets") | ||
| user = self.context["request"].user | ||
|
|
||
| with transaction.atomic(): |
There was a problem hiding this comment.
Using transaction.atomic() ensures that the order and all associated tickets are created as a single transaction, which helps maintain data integrity in case of errors during the creation process.
| queryset = queryset.filter(actors__id__in=actor_ids) | ||
|
|
||
| # Remove duplicates caused by many-to-many relationships | ||
| return queryset.distinct() |
There was a problem hiding this comment.
The distinct() method is used to remove duplicates caused by many-to-many relationships, ensuring that the queryset returns unique results.
| queryset = Order.objects.all() | ||
|
|
||
| def get_queryset(self): | ||
| return Order.objects.filter(user=self.request.user) |
There was a problem hiding this comment.
The get_queryset method restricts the orders to those belonging to the authenticated user, ensuring that users can only access their own orders.
|
|
||
| # | ||
| def perform_create(self, serializer): | ||
| serializer.save(user=self.request.user) |
There was a problem hiding this comment.
The perform_create method ensures that the order is saved with the current authenticated user, maintaining data integrity and security.
| "django-insecure-6vubhk2$++agnctay_4pxy_8cq)mosmn(*-#2b^v4cgsh-^!i3" | ||
| ) | ||
| SECRET_KEY = ("django-insecure-6vubhk2$++agnctay_4pxy_8cq)" | ||
| "mosmn(*-#2b^v4cgsh-^!i3") | ||
|
|
||
| # SECURITY WARNING: don't run with debug turned on in production! | ||
| DEBUG = True |
There was a problem hiding this comment.
The DEBUG setting is set to True, which is suitable for development but should be set to False in production to avoid exposing sensitive information.
| SECRET_KEY = ("django-insecure-6vubhk2$++agnctay_4pxy_8cq)" | ||
| "mosmn(*-#2b^v4cgsh-^!i3") |
There was a problem hiding this comment.
The SECRET_KEY should be kept secret in production environments. Consider using environment variables or a secrets manager to handle this securely.
ready solution!