Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #666

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Develop #666

wants to merge 15 commits into from

Conversation

Viesich
Copy link

@Viesich Viesich commented Nov 11, 2024

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the core functionalities and meeting the task requirements! 🎉 Your code is well-structured, and the permission classes, serializers, and views are correctly implemented. Just a couple of minor things to address: make sure to remove any duplicate files and add a blank line at the end of each file to adhere to code style guidelines. Keep up the excellent work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

@Viesich
Copy link
Author

Viesich commented Nov 11, 2024

Why are my git hub tests failing?

Copy link

@pavlopro pavlopro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests Failed

@Viesich
Copy link
Author

Viesich commented Nov 13, 2024

I didn't notice that there were tests for the cinema...
now everything is ready

@Viesich Viesich requested a review from pavlopro November 13, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants