Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_solution #669

Closed
wants to merge 2 commits into from
Closed

test_solution #669

wants to merge 2 commits into from

Conversation

xtsvi
Copy link

@xtsvi xtsvi commented Nov 16, 2024

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your hard work on this project! 😊 There are a few critical issues that need to be addressed before we can approve the pull request. Firstly, the custom permission class name should be corrected to IsAdminOrIfAuthenticatedReadOnly as per the task requirements. Additionally, ensure that the ViewSets are configured to restrict actions to only those specified, such as limiting GenreViewSet, CinemaHallViewSet, and ActorViewSet to list and create actions only. Lastly, remember to add a blank line at the end of all files to adhere to coding standards. Once these issues are resolved, your implementation will be in great shape! Keep up the great work! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

@xtsvi xtsvi closed this Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants