-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #683
Open
Lev2098
wants to merge
12
commits into
mate-academy:master
Choose a base branch
from
Lev2098:develop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Develop #683
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
f5c4602
Add custom permission for admin and authenticated users
Lev2098 0e11a8f
Add user API endpoints to URL configuration
Lev2098 485d8c6
Add user authentication URLs to the user app
Lev2098 564cfc7
Implement UserSerializer for user creation and updates
Lev2098 945eb7d
Add user creation, login, and management views
Lev2098 b58d1a0
Add authentication and permission classes to viewsets(NOT FINISHED)
Lev2098 55889cf
Add authentication and permission classes to viewsets(NOT FINISHED)
Lev2098 2345e43
Fix style and formatting issues across multiple files.
Lev2098 8f21ff3
Remove IsAdminUser permission from views.py
Lev2098 0db0a73
Use mixins for ViewSets and update settings
Lev2098 201cad7
fix: Override default authentication and permission classes for user …
Lev2098 2813158
fix syntaxis
Lev2098 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add authentication and permission classes to viewsets(NOT FINISHED)
- Loading branch information
commit b58d1a0607411c74b21ee205c09c15d1c5ffb704
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
permission_classes
forGenreViewSet
includes bothIsAdminOrIfAuthenticatedReadOnly
andIsAuthenticated
. This is redundant becauseIsAdminOrIfAuthenticatedReadOnly
already handles both admin and authenticated user permissions. You can removeIsAuthenticated
from this tuple.