solution #705
Open
solution #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dxrrkwm
approved these changes
Dec 15, 2024
Comment on lines
+4
to
+5
| from cinema.models import (Actor, CinemaHall, Genre, Movie, MovieSession, | ||
| Order, Ticket) |
Comment on lines
+4
to
+5
| from cinema.views import (ActorViewSet, CinemaHallViewSet, GenreViewSet, | ||
| MovieSessionViewSet, MovieViewSet, OrderViewSet) |
Comment on lines
+9
to
+17
| from cinema.models import Actor, CinemaHall, Genre, Movie, MovieSession, Order | ||
| from cinema.permissions import IsAdminOrIfAuthenticatedReadOnly | ||
| from cinema.serializers import (ActorSerializer, CinemaHallSerializer, | ||
| GenreSerializer, MovieDetailSerializer, | ||
| MovieListSerializer, MovieSerializer, | ||
| MovieSessionDetailSerializer, | ||
| MovieSessionListSerializer, | ||
| MovieSessionSerializer, OrderListSerializer, | ||
| OrderSerializer) |
Comment on lines
+20
to
+21
| class GenreViewSet(viewsets.GenericViewSet, | ||
| mixins.ListModelMixin, mixins.CreateModelMixin): |
There was a problem hiding this comment.
better to transfer every parent to next line, same in ActorViewSet
mateacademy-ai-mentor
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Great job on implementing the cinema application! 🎉 Your code meets the core requirements and is well-structured. There are a few minor issues, such as ensuring all files have a blank line at the end and removing any unnecessary comments or prints. Additionally, double-check for any duplicate files to keep the project clean. Keep up the good work and consider these suggestions for future improvements! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.