-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution #706
base: master
Are you sure you want to change the base?
Solution #706
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your hard work on this project! 😊 You've done a great job implementing the core functionality and meeting most of the task requirements. However, there's a critical syntax error in the import statement of your custom permission class that needs to be fixed to ensure the code runs correctly. Please correct the import statement in cinema/permissions.py
to avoid any runtime issues. Once that's addressed, your code will be in great shape! Keep up the excellent work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review
button in the Reviewers tab.
@@ -0,0 +1,16 @@ | |||
from rest_framework.permissions import BasePermission, SAFE_METHODS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a syntax error in the import statement. The correct syntax should be from rest_framework.permissions import BasePermission, SAFE_METHODS
without the /++1++/
at the end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on your submission! 🎉 Your code is well-structured and aligns with the task requirements. However, there are a few areas to improve:
-
Syntax Error in
cinema/permissions.py
: Correct the import statement by replacing the forward slash with a comma to separate the imported modules:from rest_framework.permissions import BasePermission, SAFE_METHODS
. -
Code Style: Ensure all files have a blank line at the end and remove any unnecessary comments or debugging functions.
Your implementation of viewsets and serializers is solid, and your handling of authentication and permissions is spot on. Keep up the good work, and make sure to address the mentioned issues to enhance your code quality. This decision is made to help you move forward with your learning journey. Remember to review the comments and improve your code accordingly. Keep learning and growing! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
@@ -0,0 +1,16 @@ | |||
from rest_framework.permissions import BasePermission, SAFE_METHODS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a syntax error in the import statement. Replace the forward slash with a comma to separate the imported modules: from rest_framework.permissions import BasePermission, SAFE_METHODS
.
No description provided.