Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #280

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Solution #280

wants to merge 1 commit into from

Conversation

luckezQA
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on the implementation! 🎉 While there are a few minor issues like typos and a missing semicolon, they don't critically impact the functionality. Just make sure to address these in future updates to keep your code clean and maintainable. Keep up the good work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

@@ -1,11 +1,39 @@
/// <reference types='cypress' />
import { faker } from '@faker-js/faker';
import HomeAndCataloguePageObject

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a missing semicolon at the end of the import statement for HomeAndCataloguePageObject. This might cause issues depending on your project's configuration.

homeCatalogue.clickOnProduct('Sony vaio i7');
homeCatalogue.clickOnButton('Add to cart');

homeCatalogue.verifyAddingToCart('Product added');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method verifyAddingToCart is being called with the argument 'Product added'. Ensure that this message matches exactly what is expected from the application after adding a product to the cart.

homeCatalogue.verifyAddingToCart('Product added');

homeCatalogue.clickOnLink('Cart');
homeCatalogue.verifyProductinCart('Sony vaio i7');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method verifyProductinCart is being called. Double-check the spelling of the method name and ensure it matches the actual method name in the HomeAndCataloguePageObject class. It should be verifyProductInCart if following camelCase conventions.

Comment on lines +26 to +27
verifyAddingToCart() {
return this.assertAllert('Product added');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a typo in the method name assertAllert. It should likely be assertAlert if you are trying to assert an alert message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants