Added test #292
Added test #292
Conversation
There was a problem hiding this comment.
Great job on your Pull Request! 🎉 While there are a couple of issues to address, such as ensuring credit card numbers are masked for security and correcting the use of faker.date.future(), your effort and progress are commendable. Please review the comments to improve your code. Remember, addressing these critical issues will help you avoid similar problems in the future. Keep up the good work and continue learning from these experiences! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| expirationMonth: faker.date.month(), | ||
| expirationYear: faker.date.future({ years: 5 }).getFullYear() |
There was a problem hiding this comment.
The method faker.date.future() does not accept any arguments. To get a future year, you might want to use faker.date.future().getFullYear() without passing an argument.
| cy.get('.lead').should('include.text', user.name.split(' ')[0]); | ||
| cy.get('.lead').should('include.text', user.creditCard.number); |
There was a problem hiding this comment.
Displaying the full credit card number in the UI might not be secure. Consider masking it or only showing the last few digits.
No description provided.