Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #297

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

pushkarskiyrodion
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the checkout process test script using the Page Object Model! 🎉 The code meets the task requirements and constraints effectively. There are a couple of minor issues to address: there's a typo in the test description ('propduct' should be 'product'), and consider using faker.date.future() or faker.date.past() instead of faker.date.anytime() for generating a year to ensure it fits your needs. Keep up the good work and happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

});

it('', () => {
it('should add propduct to the cart', () => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo in the test description: 'propduct' should be 'product'.

city: faker.location.city(),
creditCard: faker.finance.creditCardNumber(),
month: faker.date.month(),
year: faker.date.anytime().getFullYear()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using faker.date.anytime().getFullYear() might not be the best choice for generating a year, as anytime() returns a random date and the year could be in the past or future. Consider using faker.date.future() or faker.date.past() if you need a specific range.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants