Solution #298
Solution #298
Conversation
There was a problem hiding this comment.
Great job on implementing the task requirements and using the Page Object Model effectively! 🎉 While there are a couple of minor issues, such as the assertModalData method not verifying data values and a potential issue with faker.date.future(), these do not critically impact the functionality. Keep up the good work and consider addressing these points to enhance your code further! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| city: faker.address.city(), | ||
| creditCard: faker.finance.creditCardNumber(), | ||
| month: faker.date.month(), | ||
| year: faker.date.future({ years: 5 }).getFullYear(), |
There was a problem hiding this comment.
The method faker.date.future({ years: 5 }).getFullYear() might not work as expected because faker.date.future() returns a Date object, and calling getFullYear() directly on it may not be valid. Consider using faker.date.future(5).getFullYear() instead.
| assertModalData(name, country, city, creditCard, month, year) { | ||
| cy.contains('Id').should('be.visible'); | ||
| cy.contains('Amount').should('be.visible'); | ||
| cy.contains('Card Number').should('be.visible'); | ||
| cy.contains('Name').should('exist'); | ||
| cy.contains('Date').should('be.visible'); | ||
| cy.contains('Country').should('be.visible'); | ||
| } |
There was a problem hiding this comment.
The assertModalData method currently checks for the visibility of certain elements but does not verify that the modal contains the expected data values (name, country, city, credit card, month, year) passed as parameters. Consider adding assertions to check that these values are correctly displayed in the modal.
No description provided.