-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution_v1.0 #26
base: main
Are you sure you want to change the base?
Solution_v1.0 #26
Conversation
As for me enough to use visual studio code with needed extensions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add Products and Warehouses tables
P.S. |
Also need to check 'Lab SetUp' task from Kubernetes Basics module. Please check it |
task.sql
Outdated
CREATE TABLE Warehouses ( | ||
ID INT, | ||
WarehouseName VARCHAR(50), | ||
WarehouseAddress VARCHAR(50), | ||
PRIMARY KEY (ID) | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add a foreign key for Country ID
task.sql
Outdated
CountryID INT, | ||
FOREIGN KEY (CountryID) REFERENCES Countries (ID) ON DELETE NO ACTION, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to remove CountryID
column from this table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? Could you explain?
I moved CountryID column to Warehouses table to pass test, but I'm totally don't understand what is problem for saving countryID in ProductInventory table? If we'll want to split product by countries we'll lose in perfomance? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Need advice for using IDE. What kind of IDE better to use for devops tasks?