Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution_v1.0 #26

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

Rozdorozhnii
Copy link

Need advice for using IDE. What kind of IDE better to use for devops tasks?

@NazarSheremet
Copy link

Need advice for using IDE. What kind of IDE better to use for devops tasks?

As for me enough to use visual studio code with needed extensions

Copy link

@NazarSheremet NazarSheremet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add Products and Warehouses tables

@Rozdorozhnii
Copy link
Author

Hope understood right, I got the same data in ProductInventory table from 3 additional tables
Screenshot 2024-06-12 at 18 21 19

@Rozdorozhnii
Copy link
Author

P.S. Prettier SQL VSCode doesn't work as expected could you give advice what kind of extension better to use?

@Rozdorozhnii
Copy link
Author

Rozdorozhnii commented Jun 13, 2024

Also need to check 'Lab SetUp' task from Kubernetes Basics module. Please check it
https://mate.academy/learn/kubernetes-basics/lab-setup/linear?learnItemsFilter=All&section=practice&testTaskSlug=devops_lab_setup

task.sql Outdated
Comment on lines 12 to 17
CREATE TABLE Warehouses (
ID INT,
WarehouseName VARCHAR(50),
WarehouseAddress VARCHAR(50),
PRIMARY KEY (ID)
);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add a foreign key for Country ID

task.sql Outdated
Comment on lines 32 to 33
CountryID INT,
FOREIGN KEY (CountryID) REFERENCES Countries (ID) ON DELETE NO ACTION,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove CountryID column from this table

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? Could you explain?

@Rozdorozhnii
Copy link
Author

I moved CountryID column to Warehouses table to pass test, but I'm totally don't understand what is problem for saving countryID in ProductInventory table? If we'll want to split product by countries we'll lose in perfomance?

Copy link

@YuriiSmolii YuriiSmolii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants