Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #59

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Develop #59

wants to merge 5 commits into from

Conversation

konstantinou77
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Great job on updating the database schema to achieve the third normal form and ensuring that the ProductInventory table references Warehouses and Products using foreign keys! 🎉 Your solution meets the task requirements and constraints effectively.

However, I noticed that the Products table has duplicate product names. If this is not intentional, you might want to consider adding a UNIQUE constraint to the ProductName column to prevent duplicates in the future. Keep up the good work and continue refining your skills! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

task.sql Outdated
Comment on lines 44 to 47
(1, 'AwersomeProduct'),
(2, 'AwersomeProduct'),
(3, 'AwersomeProduct'),
(4, 'AwersomeProduct');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Products table has duplicate product names ('AwersomeProduct') with different ProductIDs. Ensure that this is intentional and aligns with your business logic. If product names should be unique, consider adding a UNIQUE constraint to the ProductName column.

Copy link

@Alkaponees Alkaponees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check output from test in Check section

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants