-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #59
base: main
Are you sure you want to change the base?
Develop #59
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on updating the database schema to achieve the third normal form and ensuring that the ProductInventory
table references Warehouses
and Products
using foreign keys! 🎉 Your solution meets the task requirements and constraints effectively.
However, I noticed that the Products
table has duplicate product names. If this is not intentional, you might want to consider adding a UNIQUE
constraint to the ProductName
column to prevent duplicates in the future. Keep up the good work and continue refining your skills! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
task.sql
Outdated
(1, 'AwersomeProduct'), | ||
(2, 'AwersomeProduct'), | ||
(3, 'AwersomeProduct'), | ||
(4, 'AwersomeProduct'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Products
table has duplicate product names ('AwersomeProduct') with different ProductIDs. Ensure that this is intentional and aligns with your business logic. If product names should be unique, consider adding a UNIQUE constraint to the ProductName
column.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check output from test in Check section
No description provided.