Skip to content

Commit

Permalink
add task solution
Browse files Browse the repository at this point in the history
  • Loading branch information
Olena7202 committed Dec 18, 2024
1 parent 9e0b1c8 commit 9b482a6
Show file tree
Hide file tree
Showing 20 changed files with 4,227 additions and 2,749 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,10 @@ name: Lint

on:
pull_request:
branches: [ master ]
branches: [master]

jobs:
run_linter:

runs-on: ubuntu-latest

strategy:
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,10 @@ name: Test

on:
pull_request:
branches: [ master ]
branches: [master]

jobs:
run_tests:

runs-on: ubuntu-latest

strategy:
Expand Down
4 changes: 2 additions & 2 deletions .stylelintrc.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module.exports = {
extends: "@mate-academy/stylelint-config",
rules: {}
extends: '@mate-academy/stylelint-config',
rules: {},
};
4 changes: 3 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
# React Decompose

Split the `App.js` into components based on CSS blocks. CSS code should be split too.

- You already have `Article`, `Header` and `Welcome` folders inside `./src/components/` with required files.
- You may also create a folder for the `Navigation` component and move navigation there.
- Tests expect you to use `export default` for all the components.

## Instructions

- Install Prettier Extention and use this [VSCode settings](https://mate-academy.github.io/fe-program/tools/vscode/settings.json) to enable format on save.
- Implement a solution following the [React task guideline](https://github.com/mate-academy/react_task-guideline#react-tasks-guideline)
- Open one more terminal and run tests with `npm test` to ensure your solutions is correct
- Replace `<your_account>` with your Github username in the [DEMO LINK](https://<your_account>.github.io/react_decompose/) and add it to the PR description
- Replace `<your_account>` with your Github username in the [DEMO LINK](https://Olena7202.github.io/react_decompose/) and add it to the PR description
3 changes: 2 additions & 1 deletion checklist.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
1. [CODE STYLE] - Don't overuse empty lines between components.

BAD EXAMPLE:

```
<A />
Expand All @@ -13,6 +14,7 @@ BAD EXAMPLE:
```

GOOD EXAMPLE:

```
<A />
<B />
Expand All @@ -21,4 +23,3 @@ GOOD EXAMPLE:

2. [PROJECT STRUCTURE] - create separate folder per component, where you could put all files(styles, components, and so on)
3. [GIT KNOWLEDGE] - check if you added ALL your files to git.

8 changes: 4 additions & 4 deletions cypress/support/component-index.html
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<meta charset="utf-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width,initial-scale=1.0">
<meta charset="utf-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<meta name="viewport" content="width=device-width,initial-scale=1.0" />
<title>Components App</title>
</head>
<body>
Expand Down
Loading

0 comments on commit 9b482a6

Please sign in to comment.