Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #3377

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add task solution #3377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,10 @@ name: Lint

on:
pull_request:
branches: [ master ]
branches: [master]

jobs:
run_linter:

runs-on: ubuntu-latest

strategy:
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,10 @@ name: Test

on:
pull_request:
branches: [ master ]
branches: [master]

jobs:
run_tests:

runs-on: ubuntu-latest

strategy:
Expand Down
4 changes: 2 additions & 2 deletions .stylelintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module.exports = {
extends: "@mate-academy/stylelint-config",
rules: {}
extends: '@mate-academy/stylelint-config',
rules: {},
};
4 changes: 3 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
# React Decompose

Split the `App.js` into components based on CSS blocks. CSS code should be split too.

- You already have `Article`, `Header` and `Welcome` folders inside `./src/components/` with required files.
- You may also create a folder for the `Navigation` component and move navigation there.
- Tests expect you to use `export default` for all the components.

## Instructions

- Install Prettier Extention and use this [VSCode settings](https://mate-academy.github.io/fe-program/tools/vscode/settings.json) to enable format on save.
- Implement a solution following the [React task guideline](https://github.com/mate-academy/react_task-guideline#react-tasks-guideline)
- Open one more terminal and run tests with `npm test` to ensure your solutions is correct
- Replace `<your_account>` with your Github username in the [DEMO LINK](https://<your_account>.github.io/react_decompose/) and add it to the PR description
- Replace `<your_account>` with your Github username in the [DEMO LINK](https://Olena7202.github.io/react_decompose/) and add it to the PR description
3 changes: 2 additions & 1 deletion checklist.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
1. [CODE STYLE] - Don't overuse empty lines between components.

BAD EXAMPLE:

```
<A />

Expand All @@ -13,6 +14,7 @@ BAD EXAMPLE:
```

GOOD EXAMPLE:

```
<A />
<B />
Expand All @@ -21,4 +23,3 @@ GOOD EXAMPLE:

2. [PROJECT STRUCTURE] - create separate folder per component, where you could put all files(styles, components, and so on)
3. [GIT KNOWLEDGE] - check if you added ALL your files to git.

8 changes: 4 additions & 4 deletions cypress/support/component-index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<meta charset="utf-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width,initial-scale=1.0">
<meta charset="utf-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<meta name="viewport" content="width=device-width,initial-scale=1.0" />
<title>Components App</title>
</head>
<body>
Expand Down
Loading
Loading