Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #2613

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,26 @@

> Here is [the working page](https://mate-academy.github.io/react_dynamic-list-of-goods/)

You have 3 button that should load [the goods](https://mate-academy.github.io/react_dynamic-list-of-goods/goods.json) and show them on the page using the `GoodsList`.
You have 3 button that should load [the goods](https://mate-academy.github.io/react_dynamic-list-of-goods/goods.json)
and show them on the page using the `GoodsList`.

1. `Load All goods` should load and show all the `goods`;
1. `Load 5 first goods` should do the next:
- load all the goods;
- sort them by name;
- and show the first 5;
- load all the goods;
- sort them by name;
- and show the first 5;
1. `Load red goods` should load all the goods show only `red` ones;
1. Server has only 1 endpoint returning all the goods, so you should do all the preparations in corresponding methods in `/api/goods`.
1. Server has only 1 endpoint returning all the goods, so you should do all the preparations in corresponding methods in
`/api/goods`.
1. `GoodsList` is almost finished, you just need to use corresponding colors for `li`s;

## Instructions
- Install Prettier Extention and use this [VSCode settings](https://mate-academy.github.io/fe-program/tools/vscode/settings.json) to enable format on save.
- Implement a solution following the [React task guideline](https://github.com/mate-academy/react_task-guideline#react-tasks-guideline).

- Install Prettier Extention and use
this [VSCode settings](https://mate-academy.github.io/fe-program/tools/vscode/settings.json) to enable format on save.
- Implement a solution following
the [React task guideline](https://github.com/mate-academy/react_task-guideline#react-tasks-guideline).
- Use the [React TypeScript cheat sheet](https://mate-academy.github.io/fe-program/js/extra/react-typescript).
- Open one more terminal and run tests with `npm test` to ensure your solution is correct.
- Replace `<your_account>` with your Github username in the [DEMO LINK](https://<your_account>.github.io/react_dynamic-list-of-goods/) and add it to the PR description.
- Replace `<your_account>` with your Github username in
the [DEMO LINK](https://LiliiaVol.github.io/react_dynamic-list-of-goods/) and add it to the PR description.
55 changes: 38 additions & 17 deletions src/App.tsx
Original file line number Diff line number Diff line change
@@ -1,27 +1,48 @@
import React from 'react';
import React, { useState } from 'react';
import './App.scss';
import { GoodsList } from './GoodsList';
import { getAll, get5First, getRedGoods } from './api/goods';
import { Good } from './types/Good';

// import { getAll, get5First, getRed } from './api/goods';
// or
// import * as goodsAPI from './api/goods';

export const App: React.FC = () => (
<div className="App">
<h1>Dynamic list of Goods</h1>
export const App: React.FC = () => {
const [goodsList, setGoodsList] = useState<Good[] | []>([]);

<button type="button" data-cy="all-button">
Load all goods
</button>
const handleButtonClick = (callback: Promise<Good[]>) => {
callback.then(setGoodsList);
};

<button type="button" data-cy="first-five-button">
Load 5 first goods
</button>
return (
<div className="App">
<h1>Dynamic list of Goods</h1>

<button type="button" data-cy="red-button">
Load red goods
</button>
<button
type="button"
data-cy="all-button"
onClick={() => handleButtonClick(getAll())}
>
Load all goods
</button>

<GoodsList goods={[]} />
</div>
);
<button
type="button"
data-cy="first-five-button"
onClick={() => handleButtonClick(get5First())}
>
Load 5 first goods
</button>

<button
type="button"
data-cy="red-button"
onClick={() => handleButtonClick(getRedGoods())}
>
Load red goods
</button>

<GoodsList goods={goodsList} />
</div>
);
};
2 changes: 1 addition & 1 deletion src/GoodsList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ type Props = {
export const GoodsList: React.FC<Props> = ({ goods }) => (
<ul>
{goods.map(good => (
<li key={good.id} data-cy="good">
<li key={good.id} data-cy="good" style={{ color: good.color }}>
{good.name}
</li>
))}
Expand Down
11 changes: 9 additions & 2 deletions src/api/goods.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,16 @@ export function getAll(): Promise<Good[]> {
}

export const get5First = () => {
return getAll().then(goods => goods); // sort and get the first 5
return getAll()
.then(goods => goods)
.then(goods =>
goods.sort((good1, good2) => good1.name.localeCompare(good2.name)),
)
.then(goods => goods.slice(0, 5)); // sort and get the first 5
};

export const getRedGoods = () => {
return getAll().then(goods => goods); // get only red
return getAll()
.then(goods => goods)
.then(goods => goods.filter(good => good.color === 'red')); // get only red
};
Loading