Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

develop #1065

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

develop #1065

wants to merge 7 commits into from

Conversation

mykyta01
Copy link

@mykyta01 mykyta01 commented Mar 21, 2024

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's make your code better

src/App.tsx Outdated Show resolved Hide resolved
src/components/PostsList.tsx Outdated Show resolved Hide resolved
Comment on lines 76 to 80
onClick={() => {
setSelectedUser(user);
setSelectedPost(null);
setIsVisible(false);
}}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this logic from jsx to the helper function and use it here

mykyta01 and others added 2 commits August 25, 2024 19:29
Co-authored-by: Volodymyr Soltys <[email protected]>
Copy link

@vadiimvooo vadiimvooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants