Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add solution #1131

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add solution #1131

wants to merge 2 commits into from

Conversation

Nazarin565
Copy link

DEMO

Everything works correctly, but 2 same tests don`t pass :(

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your code

  1. The name and comment cannot be only spaces
image

@@ -1,42 +1,162 @@
import React from 'react';
/* eslint-disable @typescript-eslint/indent */

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/* eslint-disable @typescript-eslint/indent */

src/App.tsx Outdated
No posts yet
</div>
{currentUser &&
posts.length === 0 &&

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
posts.length === 0 &&
!posts.length &&

src/App.tsx Outdated
{currentUser &&
!isPostError &&
!isPostLoading &&
posts.length > 0 && (

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
posts.length > 0 && (
!!posts.length && (

<button
type="reset"
className="button is-link is-light"
onClick={() => reset()}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
onClick={() => reset()}
onClick={reset}

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants