Develop #1163
Open
Develop #1163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volodymyr-soltys97
suggested changes
Sep 14, 2024
volodymyr-soltys97
suggested changes
Sep 14, 2024
src/App.tsx
Outdated
| </div> | ||
| )} | ||
|
|
||
| {!hasError && userPosts.length > 0 && ( |
There was a problem hiding this comment.
Suggested change
| {!hasError && userPosts.length > 0 && ( | |
| {!hasError && !!userPosts.length && ( |
src/components/PostDetails.tsx
Outdated
Comment on lines
110
to
133
| <article | ||
| key={comment.id} | ||
| className="message is-small" | ||
| data-cy="Comment" | ||
| > | ||
| <div className="message-header"> | ||
| <a href={`mailto:${comment.email}`} data-cy="CommentAuthor"> | ||
| {comment.name} | ||
| </a> | ||
| <button | ||
| data-cy="CommentDelete" | ||
| type="button" | ||
| className={classNames('button delete is-small', { | ||
| 'is-loading': deletingCommentId === comment.id, | ||
| })} | ||
| aria-label="delete" | ||
| onClick={() => handleDeleteComment(comment.id)} | ||
| ></button> | ||
| </div> | ||
|
|
||
| <div className="message-body" data-cy="CommentBody"> | ||
| {comment.body} | ||
| </div> | ||
| </article> |
There was a problem hiding this comment.
Move this logic to the CommentInfo component
src/components/PostDetails.tsx
Outdated
| </div> | ||
|
|
||
| <div className="message-body" data-cy="CommentBody"> | ||
| {comment.body} |
There was a problem hiding this comment.
Use destructuring for comment
src/components/PostsList.tsx
Outdated
| data-cy="PostButton" | ||
| className={classNames('button is-link', { | ||
| 'is-light': selectedPost?.id !== post.id, | ||
| })} // //Close (not is-light) |
There was a problem hiding this comment.
Suggested change
| })} // //Close (not is-light) | |
| })} |
src/components/UserSelector.tsx
Outdated
| href={`#user-${user.id}`} | ||
| className={classNames('dropdown-item', { | ||
| 'is-active': selectedUser && selectedUser.id === user.id, | ||
| })} //is-active |
There was a problem hiding this comment.
Suggested change
| })} //is-active | |
| })} |
GUSILLUS
suggested changes
Sep 15, 2024
src/components/PostDetails.tsx
Outdated
| eveniet quo quis laborum totam consequatur non dolor ut et est | ||
| repudiandae est voluptatem vel debitis et magnam | ||
| </p> | ||
| <p data-cy="PostBody">{post.body}</p> |
There was a problem hiding this comment.
Consider using destruction assignment to post object
src/components/PostDetails.tsx
Outdated
| data-cy="WriteCommentButton" | ||
| type="button" | ||
| className="button is-link" | ||
| onClick={() => setIsFormActive(true)} |
src/components/PostsList.tsx
Outdated
| </thead> | ||
|
|
||
| <tbody> | ||
| {posts.map(post => ( |
src/components/UserSelector.tsx
Outdated
| </a> | ||
| {users.map(user => ( | ||
| <a | ||
| key={user.id} |
|
Не впевнена що я правильно зрозуміла, що потрібно було виправити |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK
Не проходить 2 тести, але якщо дивитись в браузері DevTools, то все працює коректно ніби
