-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task solution #1178
base: master
Are you sure you want to change the base?
add task solution #1178
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,60 +1,187 @@ | ||
import classNames from 'classnames'; | ||
/* eslint-disable @typescript-eslint/indent */ | ||
|
||
import classNames from 'classnames'; | ||
import 'bulma/css/bulma.css'; | ||
import '@fortawesome/fontawesome-free/css/all.css'; | ||
import './App.scss'; | ||
import { useEffect, useState } from 'react'; | ||
|
||
import { PostsList } from './components/PostsList'; | ||
import { PostDetails } from './components/PostDetails'; | ||
import { UserSelector } from './components/UserSelector'; | ||
import { PostDetails } from './components/PostDetails'; | ||
import { PostsList } from './components/PostsList'; | ||
import { Loader } from './components/Loader'; | ||
import { Comment, CommentData } from './types/Comment'; | ||
import { User } from './types/User'; | ||
import { Post } from './types/Post'; | ||
import { | ||
addNewComment, | ||
deleteComment, | ||
getUserPostComments, | ||
getUserPosts, | ||
getUsers, | ||
} from './api/post'; | ||
|
||
export const App = () => ( | ||
<main className="section"> | ||
<div className="container"> | ||
<div className="tile is-ancestor"> | ||
<div className="tile is-parent"> | ||
<div className="tile is-child box is-success"> | ||
<div className="block"> | ||
<UserSelector /> | ||
</div> | ||
export const App = () => { | ||
const [users, setUsers] = useState<User[]>([]); | ||
const [userSelected, setUserSelected] = useState<User | null>(null); | ||
const [showPostLoader, setShowPostLoader] = useState<boolean>(false); | ||
const [showCommentLoader, setShowCommentLoader] = useState<boolean>(false); | ||
const [isAddingComment, setIsAddingComment] = useState(false); | ||
const [userPosts, setUserPosts] = useState<Post[]>([]); | ||
const [selectedPost, setSelectedPost] = useState<Post | null>(null); | ||
const [isSidebarVisible, setIsSidebarVisible] = useState<number | null>(null); | ||
const [postComments, setPostComments] = useState<Comment[]>([]); | ||
const [hasPostError, setHasPostError] = useState<boolean>(false); | ||
const [hasCommentError, setHasCommentError] = useState<boolean>(false); | ||
const [isCommentFormVisible, setIsCommentFormVisible] = useState(false); | ||
|
||
<div className="block" data-cy="MainContent"> | ||
<p data-cy="NoSelectedUser">No user selected</p> | ||
useEffect(() => { | ||
getUsers() | ||
.then(res => { | ||
setUsers(res as User[]); | ||
}) | ||
.catch(() => new Error('Failed to fetch users')); | ||
}, []); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You should handle the error in catch block. It's better to set some state variable in case of error and show error message to the user. |
||
|
||
Comment on lines
+38
to
+44
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You're not handling potential errors from the |
||
<Loader /> | ||
const fetchUserPosts = (user: User) => { | ||
setShowPostLoader(true); | ||
getUserPosts(user.id) | ||
.then(res => { | ||
setUserPosts(res as Post[]); | ||
setHasPostError(false); | ||
}) | ||
.catch(() => { | ||
setHasPostError(true); | ||
}) | ||
.finally(() => { | ||
setShowPostLoader(false); | ||
}); | ||
}; | ||
Comment on lines
+46
to
+58
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The same issue with error handling is present in the
Comment on lines
+46
to
+58
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You should follow the checklist: don't use setState several times in one function call (method) (it's better for clarity of the code). You can use |
||
|
||
<div | ||
className="notification is-danger" | ||
data-cy="PostsLoadingError" | ||
> | ||
Something went wrong! | ||
</div> | ||
const fetchPostComments = (currentPost: Post) => { | ||
setIsSidebarVisible(currentPost.id); | ||
setShowCommentLoader(true); | ||
|
||
setSelectedPost(currentPost); | ||
|
||
<div className="notification is-warning" data-cy="NoPostsYet"> | ||
No posts yet | ||
getUserPostComments(currentPost.id) | ||
.then(res => { | ||
setPostComments(res as Comment[]); | ||
setHasCommentError(false); | ||
}) | ||
.catch(() => { | ||
setHasCommentError(true); | ||
}) | ||
.finally(() => { | ||
setShowCommentLoader(false); | ||
}); | ||
}; | ||
Comment on lines
+61
to
+77
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The same issue with error handling is present in the
Comment on lines
+61
to
+77
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as previous, you should follow the checklist: don't use setState several times in one function call (method) (it's better for clarity of the code). You can use |
||
|
||
const removeComment = (commentId: number) => { | ||
deleteComment(commentId) | ||
.then(() => { | ||
setPostComments(prevPostComments => | ||
prevPostComments.filter( | ||
(comment: Comment) => comment.id !== commentId, | ||
), | ||
); | ||
}) | ||
.catch(() => new Error('Failed to delete comment')); | ||
}; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You should handle the error in catch block. It's better to set some state variable in case of error and show error message to the user. |
||
|
||
Comment on lines
+80
to
+90
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The same issue with error handling is present in the |
||
const createComment = (newComment: CommentData) => { | ||
setIsAddingComment(true); | ||
addNewComment(newComment) | ||
.then(res => { | ||
setPostComments([...postComments, res as Comment]); | ||
setIsAddingComment(false); | ||
}) | ||
.catch(() => new Error('Failed to add comment')); | ||
}; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You should handle the error in catch block. It's better to set some state variable in case of error and show error message to the user. |
||
|
||
Comment on lines
+92
to
+100
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The same issue with error handling is present in the |
||
return ( | ||
<main className="section"> | ||
<div className="container"> | ||
<div className="tile is-ancestor"> | ||
<div className="tile is-parent"> | ||
<div className="tile is-child box is-success"> | ||
<div className="block"> | ||
<UserSelector | ||
users={users} | ||
setUserSelected={setUserSelected} | ||
userSelected={userSelected} | ||
handleUserPosts={fetchUserPosts} | ||
setShowSideBar={setIsSidebarVisible} | ||
/> | ||
</div> | ||
|
||
<PostsList /> | ||
<div className="block" data-cy="MainContent"> | ||
{!userSelected && ( | ||
<p data-cy="NoSelectedUser">No user selected</p> | ||
)} | ||
|
||
{showPostLoader && <Loader />} | ||
|
||
{hasPostError && ( | ||
<div | ||
className="notification is-danger" | ||
data-cy="PostsLoadingError" | ||
> | ||
Something went wrong! | ||
</div> | ||
)} | ||
|
||
{userPosts.length > 0 && !showPostLoader && ( | ||
<PostsList | ||
userPosts={userPosts} | ||
handleShowComment={fetchPostComments} | ||
showSideBar={isSidebarVisible} | ||
setShowSideBar={setIsSidebarVisible} | ||
setShowCommentForm={setIsCommentFormVisible} | ||
/> | ||
)} | ||
{userSelected && | ||
userPosts.length === 0 && | ||
!showPostLoader && | ||
!hasPostError && ( | ||
<div | ||
className="notification is-warning" | ||
data-cy="NoPostsYet" | ||
> | ||
No posts yet | ||
</div> | ||
)} | ||
</div> | ||
</div> | ||
</div> | ||
</div> | ||
|
||
<div | ||
data-cy="Sidebar" | ||
className={classNames( | ||
'tile', | ||
'is-parent', | ||
'is-8-desktop', | ||
'Sidebar', | ||
'Sidebar--open', | ||
)} | ||
> | ||
<div className="tile is-child box is-success "> | ||
<PostDetails /> | ||
<div | ||
data-cy="Sidebar" | ||
className={classNames( | ||
'tile', | ||
'is-parent', | ||
'is-8-desktop', | ||
'Sidebar', | ||
{ 'Sidebar--open': isSidebarVisible }, | ||
)} | ||
> | ||
<div className="tile is-child box is-success "> | ||
<PostDetails | ||
isCommentLoading={showCommentLoader} | ||
postComments={postComments} | ||
selectedPost={selectedPost} | ||
errorsComment={hasCommentError} | ||
onDeleteComment={removeComment} | ||
onAddComment={createComment} | ||
isButtonAddLoading={isAddingComment} | ||
onShowCommentFormChange={setIsCommentFormVisible} | ||
isCommentFormVisible={isCommentFormVisible} | ||
userSelected={userSelected} | ||
/> | ||
</div> | ||
</div> | ||
</div> | ||
</div> | ||
</div> | ||
</main> | ||
); | ||
</main> | ||
); | ||
}; | ||
Comment on lines
+102
to
+186
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The render method is quite long and contains a lot of logic. It would be better to split it into smaller, well-named components to make the code more readable and maintainable. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
import { CommentData } from '../types/Comment'; | ||
import { client } from '../utils/fetchClient'; | ||
|
||
export const getUsers = () => { | ||
return client.get('/users'); | ||
}; | ||
|
||
export const getUserPosts = (userId: number) => { | ||
return client.get(`/posts?userId=${userId}`); | ||
}; | ||
|
||
export const getUserPostComments = (postId: number) => { | ||
return client.get(`/comments?postId=${postId}`); | ||
}; | ||
|
||
export const addNewComment = (newComment: CommentData) => { | ||
return client.post('/comments', newComment); | ||
}; | ||
|
||
export const deleteComment = (commentId: number) => { | ||
return client.delete(`/comments/${commentId}`); | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can group your imports to make them more readable. For example, you can first import libraries (like
react
,classnames
, etc.), then styles, then components, and lastly utilities and types.