solution

[Shevchuchka]

https://shevchuchka.github.io/react_dynamic-list-of-posts/

[mateacademy-ai-mentor]

Thank you for your hard work on this project! While your code generally meets the task requirements, there are a few critical issues that need to be addressed before we can approve the pull request:

1. Error Handling: The error handling in your code could be improved. For example, directly throwing errors in the catch block can lead to unhandled promise rejections. It's important to handle errors more gracefully, perhaps by setting an error state or notifying the user.

2. Prop Default Values: Setting default values for props like setSelectedPost, setShowForm, and addFunction to empty functions can lead to unexpected behavior. Consider making these props required instead of providing default values.

3. Event Handling: The onSubmit function in NewCommentForm.tsx is missing the event parameter, which is necessary for calling preventDefault() correctly.

4. Fetch Error Handling: The getUsers call lacks error handling, which could lead to silent failures. Adding error handling will improve user feedback and prevent potential issues.

Please address these issues to ensure the functionality and reliability of your application. Keep up the great work, and don't hesitate to reach out if you need any help! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

[mateacademy-ai-mentor]

Consider adding error handling for the getUsers call to manage potential errors during the fetch operation. This will help prevent silent failures and improve user feedback.

[mateacademy-ai-mentor]

The error handling here sets a generic error state. Consider providing more detailed error information to the user to help diagnose issues more effectively.

[mateacademy-ai-mentor]

Setting a default value for addFunction to an empty function can lead to unexpected behavior if the prop is not provided. Consider making this prop required without a default value.

[mateacademy-ai-mentor]

The onSubmit function is missing the event parameter. You need to include event as a parameter to use event.preventDefault() correctly.

[mateacademy-ai-mentor]

Setting a default value for setShowForm to an empty function can lead to unexpected behavior if the prop is not provided. Consider making this prop required without a default value.

[mateacademy-ai-mentor]

Throwing an error directly in the catch block is not a good practice as it can lead to unhandled promise rejections. Consider handling the error more gracefully, perhaps by setting an error state or displaying a notification to the user.

[mateacademy-ai-mentor]

Setting a default value for setSelectedPost to an empty function can lead to unexpected behavior if the prop is not provided. Consider making this prop required without a default value.

[mateacademy-ai-mentor]

Setting a default value for setSelectedPost to an empty function can lead to unexpected behavior if the prop is not provided. Consider making this prop required without a default value.

[volodymyr-soltys97]

Good job!
Let's improve your code
After clicking on the user, nothing happens, you need to open comments

[volodymyr-soltys97]

Good job!
Let's improve your code
The comment cannot be only spaces

Fix the comment block position, check it on the working example

Add a correct type to input of email

[volodymyr-soltys97]

All states must be at the beginning of the component

[VitaliyBondarenko1982]

Looks good

[VitaliyBondarenko1982]

Suggested change

	if (selectedPost && selectedPost.id === currentPost.id) {
	return true;
	} else {
	return false;
	}
	return selectedPost && selectedPost.id === currentPost.id

it will be the same.