implented #918
Open
implented #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VitaliyBondarenko1982
suggested changes
Sep 21, 2023
There was a problem hiding this comment.
Compare your implementation with working example
do not show right side bar when no selected any post
IvanFesenko
suggested changes
Sep 21, 2023
src/components/NewCommentForm.tsx
Outdated
Comment on lines
18
to
23
| const [name, setName] = useState(''); | ||
| const [isNameError, setIsNameError] = useState(false); | ||
| const [email, setEmail] = useState(''); | ||
| const [isEmailError, setIsEmailError] = useState(false); | ||
| const [body, setBody] = useState(''); | ||
| const [isBodyError, setIsBodyError] = useState(false); |
There was a problem hiding this comment.
My assumption it's better to have 2 states instead of 6. One for fields
const [form, setForm] = useState({
name: '',
....
});
second for error message< by default it's empty string
const [errorMsg, setErrorMsg] = useState('');
src/components/NewCommentForm.tsx
Outdated
Comment on lines
89
to
92
| onChange={(e) => { | ||
| setName(e.target.value); | ||
| setIsNameError(false); | ||
| }} |
There was a problem hiding this comment.
Do not use anonymous function use separate handler
It will works for all fields
const onFieldChange = ({taget: {value, name}}) => {
setForm(prevState => {...prevState, [name]: value })
}
mykhalenych
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ZadorozhnyiYevhenii.github.io/react_dynamic-list-of-posts/