task solution was added #926
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxim2310
suggested changes
Sep 28, 2023
There was a problem hiding this comment.
Great job overall! Just couple tiny things needs to be fixed before approval)
- when after error i have correct request i still have error message
- and the same after bad request for comment i cant reach good scenario
- need to add email validation
- after adding new comment need to clear inputs
anastasiia-tilikina
suggested changes
Sep 29, 2023
VitaliyBodnar
suggested changes
Sep 29, 2023
src/components/NewCommentForm.tsx
Outdated
Comment on lines
184
to
185
| setBody(event.target.value); | ||
| setIsBodyError(false); |
There was a problem hiding this comment.
it is bad practise to make anonymous arrow functions in jsx.
make handler in component and pass reference here
src/components/PostDetails.tsx
Outdated
| Misha Hrynko | ||
| </a> | ||
| return ( | ||
| <> |
There was a problem hiding this comment.
don't see any sense to use <> here, because there is only one element inside
src/components/PostsList.tsx
Outdated
| getComments(post.id) | ||
| .then(setComments) | ||
| .catch(() => { | ||
| setIsCommentLoading(false); |
There was a problem hiding this comment.
you already have setIsCommentLoading in finally block
src/components/PostsList.tsx
Outdated
Comment on lines
77
to
79
| handleOpenPostClick(post); | ||
| setIsCommentLoadError(false); | ||
| setIsCommentDeleteError(false); |
There was a problem hiding this comment.
it is bad practise to make anonymous arrow functions in jsx.
make handler in component and pass reference here
lerastarynets
approved these changes
Sep 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK