pushing #946

victorgri · 2023-11-01T12:41:28Z

No description provided.

lerastarynets

Pls attach a link to deployed project and fix comments

lerastarynets · 2023-11-01T12:52:35Z

src/App.tsx


 export const App: React.FC = () => {
+  const [users, setUsers] = useState<User[]>([]);
+  const [posts, setPosts] = useState<Post[]>([]);
+  const [userId, setUserId] = useState<User['id']>(0);


setUserId is assigned a value but never used

lerastarynets · 2023-11-01T12:52:59Z

src/App.tsx

+import { Post } from './types/Post';
+import { PostsList } from './components/PostsList';
+
+// import { Loader } from './components/Loader';


remove all redundant comments pls

lerastarynets · 2023-11-01T12:53:37Z

src/App.tsx

+    getUsers().then((usersFromserver) => setUsers(usersFromserver));
+  };
+
+  loadPosts();


why do u call this function here instead of doing it inside useEffect?

lerastarynets · 2023-11-01T12:53:52Z

src/App.tsx

-                </div>
-
-                <PostsList />
+                {posts.length === 0 ? (


Suggested change

{posts.length === 0 ? (

{!posts.length ? (

lerastarynets · 2023-11-01T12:54:22Z

src/components/PostDetails.tsx

  return (
    <div className="content" data-cy="PostDetails">
      <div className="content" data-cy="PostDetails">
        <div className="block">
          <h2 data-cy="PostTitle">
-            #18: voluptate et itaque vero tempora molestiae
+            {`#${post.id}: ${post.title}`}


pls destructure post and comment

lerastarynets · 2023-11-01T12:54:43Z

src/components/PostsList.tsx

+          </tr>
+        </thead>
+        {posts.map((post) => (
+          <tbody>


where is key prop

lerastarynets · 2023-11-01T12:55:17Z

src/components/PostsList.tsx

+          </tr>
+        </thead>
+        {posts.map((post) => (
+          <tbody>


map should be inside <tbody>, you should only map table rows, not bodies

lerastarynets · 2023-11-01T12:55:54Z

src/components/Users.tsx

+export const Users: React.FC<Props> = ({ users }) => {
+  return (
+    <div className="dropdown-content">
+      {users.map((user) => (


pls destructure user

lerastarynets

I still can't see a link to your deployed project, pls fix)

lerastarynets · 2023-11-02T09:26:11Z

src/App.tsx

-                  No posts yet
-                </div>
+                {selectedUser
+                  && userPosts.length === 0


Suggested change

&& userPosts.length === 0

&& !userPosts.length

lerastarynets · 2023-11-02T09:26:20Z

src/App.tsx


-                <PostsList />
+                {selectedUser && userPosts.length > 0 && (


Suggested change

{selectedUser && userPosts.length > 0 && (

{selectedUser && !!userPosts.length && (

lerastarynets · 2023-11-02T09:27:41Z

src/components/PostDetails.tsx

+          {!loader
+            && !errorMessage
+            && postComments
+            && postComments.length === 0 && (


Suggested change

&& postComments.length === 0 && (

&& !postComments.length && (

If a mentor points out a mistake, it means that you need to fix ALL occurrences of the mistake, not only in the place where the comment was left.

lerastarynets · 2023-11-02T09:28:58Z

src/App.tsx

+                {selectedUser
+                  && userPosts.length === 0
+                  && !errorMessage
+                  && !loader && (


also pls consider moving long ternaries to separate consts with consistent names

https://victorgri.github.io/react_dynamic-list-of-posts/

lerastarynets

When user add comment, it's name and email should remain in the form, while comment text should be cleared, ur logic works vice versa right now, pls fix

lerastarynets · 2023-11-02T10:15:29Z

src/components/PostDetails.tsx

-              >
-                Misha Hrynko
-              </a>
+          {!errorMessage && postComments && postComments.length > 0 && (


Suggested change

{!errorMessage && postComments && postComments.length > 0 && (

{!errorMessage && postComments && !!postComments.length && (

loralevitska

Hi, I see you haven't fixed previous comments, maybe you did not push your changes? If you have any questions, please ask them in fe_chat and tag mentors. It will be faster, because your answers in GitHub will be visible to mentor only after you re-request review

loralevitska · 2023-11-02T17:27:56Z

src/App.tsx

+  const [userPosts, setUserPosts] = useState<Post[]>([]);
+  const [selectedUser, setSelectedUser] = useState<User>();
+  const [selectedPost, setSelectedPost] = useState<Post>();
+  const [loader, setLoader] = useState<boolean>(false);


Rename all boolean variables using tips

Suggested change

const [loader, setLoader] = useState<boolean>(false);

const [isLoading, setIsLoading] = useState<boolean>(false);

loralevitska · 2023-11-02T17:28:40Z

src/App.tsx

+                {selectedUser
+                  && !userPosts.length
+                  && !errorMessage
+                  && !loader && (


Please fix it

loralevitska · 2023-11-02T17:31:52Z

src/components/UserSelector.tsx

+  const closeDropDown = () => {
+    setTimeout(() => {
+      setIsActiveDropDown(false);
+    }, 150); // Maybe more


Google best practises
And remove comment
Take responsibility to your code 😄

loralevitska · 2023-11-02T17:32:53Z

src/components/UserSelector.tsx

+  const closeDropDown = () => {
+    setTimeout(() => {
+      setIsActiveDropDown(false);
+    }, 150); // Maybe more


Google best practice
And remove comment
Take responsibility to your code 😃

nazarmatsevych

Now I can't choose a user, try to fix it

Next time please check your demo link before making re-request.

If you have any questions - feel free to ask them in fe_chat.

maxim2310

1 if you are trying to delete comment and have an error, you must to return comment
2. need to add validation on email

SanyaBratashchuk

I should not be able to submit form if there is validation errors

SanyaBratashchuk · 2023-11-05T09:45:38Z

src/components/NewCommentForm.tsx

+      setNameError(FormErrors.Name);
+    }
+
+    // eslint-disable-next-line no-useless-escape


it is better to fix eslint error

pushing

981356e

lerastarynets suggested changes Nov 1, 2023

View reviewed changes

solution

bb1478e

victorgri requested a review from lerastarynets November 2, 2023 09:11

lerastarynets suggested changes Nov 2, 2023

View reviewed changes

fixed

7bc24b3

victorgri requested a review from lerastarynets November 2, 2023 09:43

lerastarynets suggested changes Nov 2, 2023

View reviewed changes

third try

297879d

victorgri requested a review from lerastarynets November 2, 2023 17:20

loralevitska suggested changes Nov 2, 2023

View reviewed changes

Victor Hrygorash added 4 commits November 2, 2023 20:09

done

245faee

done

098f03d

fixed all

5bec440

donedonedone

8dd8836

victorgri requested a review from loralevitska November 2, 2023 19:16

nazarmatsevych suggested changes Nov 2, 2023

View reviewed changes

fixed all

487818e

victorgri requested a review from nazarmatsevych November 3, 2023 08:38

maxim2310 suggested changes Nov 3, 2023

View reviewed changes

fixxx

14eef94

victorgri requested a review from maxim2310 November 4, 2023 18:45

SanyaBratashchuk suggested changes Nov 5, 2023

View reviewed changes

done

36144a3

victorgri requested a review from SanyaBratashchuk November 6, 2023 07:57

OleziO approved these changes Nov 6, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pushing #946

pushing #946

victorgri commented Nov 1, 2023

lerastarynets left a comment

lerastarynets Nov 1, 2023

lerastarynets Nov 1, 2023

lerastarynets Nov 1, 2023

lerastarynets Nov 1, 2023

lerastarynets Nov 1, 2023

lerastarynets Nov 1, 2023

lerastarynets Nov 1, 2023

lerastarynets Nov 1, 2023

lerastarynets left a comment

lerastarynets Nov 2, 2023

lerastarynets Nov 2, 2023

lerastarynets Nov 2, 2023

lerastarynets Nov 2, 2023

victorgri Nov 2, 2023

lerastarynets left a comment

lerastarynets Nov 2, 2023

loralevitska left a comment

loralevitska Nov 2, 2023

loralevitska Nov 2, 2023

loralevitska Nov 2, 2023

loralevitska Nov 2, 2023

nazarmatsevych left a comment

maxim2310 left a comment

SanyaBratashchuk left a comment

SanyaBratashchuk Nov 5, 2023

	{selectedUser && userPosts.length > 0 && (
	{selectedUser && !!userPosts.length && (

	&& postComments.length === 0 && (
	&& !postComments.length && (

	{!errorMessage && postComments && postComments.length > 0 && (
	{!errorMessage && postComments && !!postComments.length && (

	const [loader, setLoader] = useState<boolean>(false);
	const [isLoading, setIsLoading] = useState<boolean>(false);

pushing #946

Are you sure you want to change the base?

pushing #946

Conversation

victorgri commented Nov 1, 2023

lerastarynets left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lerastarynets left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lerastarynets left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

loralevitska left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nazarmatsevych left a comment

Choose a reason for hiding this comment

maxim2310 left a comment

Choose a reason for hiding this comment

SanyaBratashchuk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment