add solution #947
Closed
add solution #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OleziO
suggested changes
Nov 2, 2023
src/App.tsx
Outdated
| }, [isLoaderActive, activeUser, userPosts]); | ||
|
|
||
| const isPostListShow = useMemo(() => { | ||
| return !isLoaderActive && userPosts.length > 0; |
There was a problem hiding this comment.
Suggested change
| return !isLoaderActive && userPosts.length > 0; | |
| return !isLoaderActive && userPosts.length; |
| type RequestMethod = 'GET' | 'POST' | 'PATCH' | 'DELETE'; | ||
|
|
||
| function request<T>( | ||
| url: string, | ||
| method: RequestMethod = 'GET', | ||
| data: any = null, // we can send any data to the server | ||
| data: any = null, |
anastasiiavorobiova
suggested changes
Nov 2, 2023
witflash
approved these changes
Nov 2, 2023
src/App.tsx
Outdated
Comment on lines
34
to
35
| .catch(() => {}) | ||
| .finally(() => {}); |
There was a problem hiding this comment.
Why do you need these blocks?
If you didn't use them it's better to remove them.
src/components/UserSelector.tsx
Outdated
Comment on lines
17
to
18
| setActiveUser = () => {}, | ||
| getUserPost = () => {}, |
There was a problem hiding this comment.
I think you don't need to default these functions in the props argument. As I see, these props are required in the Props interface. So they should exist anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dimarogkov.github.io/react_dynamic-list-of-posts/