add task solution #1869
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,34 +1,73 @@ | ||
| import React from 'react'; | ||
| import { TodosFilter } from '../../types/TodosFilter'; | ||
|
|
||
| type Props = { | ||
| query: string; | ||
| filter: TodosFilter; | ||
| onQueryChange: (value: string) => void; | ||
| onFilterChange: (value: TodosFilter) => void; | ||
| }; | ||
|
|
||
| export const TodoFilter: React.FC<Props> = ({ | ||
| query, | ||
| filter, | ||
| onQueryChange, | ||
| onFilterChange, | ||
| }) => { | ||
| const handleReset = () => { | ||
| onQueryChange(''); | ||
| onFilterChange(TodosFilter.All); | ||
| }; | ||
|
|
||
| return ( | ||
| <form className="field has-addons"> | ||
| <p className="control"> | ||
| <span className="select"> | ||
| <select | ||
| data-cy="statusSelect" | ||
| className="is-capitalized" | ||
| value={filter} | ||
| onChange={event => ( | ||
| onFilterChange(event?.target.value as TodosFilter) | ||
| )} | ||
|
Comment on lines
+30
to
+32
There was a problem hiding this comment. Pass a handler as prop from app, which will change ur filterParam to event.target.value and set proper types, it will shorten ur code and will make it look simpler |
||
| > | ||
| {Object.values(TodosFilter).map(value => ( | ||
| <option | ||
| value={value} | ||
| key={value} | ||
| > | ||
| {value} | ||
| </option> | ||
| ))} | ||
| </select> | ||
| </span> | ||
| </p> | ||
|
|
||
| <p className="control is-expanded has-icons-left has-icons-right"> | ||
| <input | ||
| data-cy="searchInput" | ||
| type="text" | ||
| className="input" | ||
| placeholder="Search..." | ||
| value={query} | ||
| onChange={(event) => onQueryChange(event.target.value)} | ||
|
|
||
| /> | ||
| <span className="icon is-left"> | ||
| <i className="fas fa-magnifying-glass" /> | ||
| </span> | ||
|
|
||
| <span className="icon is-right" style={{ pointerEvents: 'all' }}> | ||
|
There was a problem hiding this comment. Using inline styles is a bad practice, use css instead. There was a problem hiding this comment. It was already implemented in code of the task. |
||
| {query && ( | ||
| <button | ||
| data-cy="clearSearchButton" | ||
| type="button" | ||
| className="delete" | ||
| aria-label="Clear Search" | ||
| onClick={handleReset} | ||
| /> | ||
| )} | ||
| </span> | ||
| </p> | ||
| </form> | ||
| ); | ||
| }; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| import React from 'react'; | ||
| import cn from 'classnames'; | ||
| import { Todo } from '../../types/Todo'; | ||
|
|
||
| type Props = { | ||
| todo: Todo; | ||
| selectedTodo: Todo | null; | ||
| onSelectTodo: (todo: Todo) => void; | ||
| }; | ||
|
|
||
| export const TodoItem: React.FC<Props> = ({ | ||
| todo, | ||
| selectedTodo, | ||
| onSelectTodo, | ||
| }) => { | ||
| const { id, title, completed } = todo; | ||
| const isTodoSelected = selectedTodo === todo; | ||
|
|
||
| return ( | ||
| <tr | ||
| data-cy="todo" | ||
| className={cn({ 'has-background-info-light': isTodoSelected })} | ||
| > | ||
| <td className="is-vcentered">{id}</td> | ||
| <td className="is-vcentered"> | ||
| {completed && ( | ||
| <span className="icon" data-cy="iconCompleted"> | ||
| <i className="fas fa-check" /> | ||
| </span> | ||
| )} | ||
| </td> | ||
| <td className="is-vcentered is-expanded"> | ||
| <p className={cn({ | ||
| 'has-text-success': completed, | ||
| 'has-text-danger': !completed, | ||
| })} | ||
| > | ||
| {title} | ||
| </p> | ||
| </td> | ||
| <td className="has-text-right is-vcentered"> | ||
| <button | ||
| data-cy="selectButton" | ||
| className="button" | ||
| type="button" | ||
| onClick={() => onSelectTodo(todo)} | ||
| > | ||
| <span className="icon"> | ||
| <i className={cn( | ||
| 'far', | ||
| { | ||
| 'fa-eye': !isTodoSelected, | ||
| 'fa-eye-slash': isTodoSelected, | ||
| }, | ||
| )} | ||
| /> | ||
| </span> | ||
| </button> | ||
| </td> | ||
| </tr> | ||
| ); | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export * from './TodoItem'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can group it into one object, like filterParams
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be kept in three different states.