react_dynamic-list-of-todos_v-01 #1952
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etojeDenys
suggested changes
Oct 24, 2023
src/App.tsx
Outdated
Comment on lines
17
to
18
| const [query, setQuery] = useState<string>(''); | ||
| const [status, setStatus] = useState<string>('all'); |
There was a problem hiding this comment.
it's redundant to specify the primitive types
DarkMistyRoom
suggested changes
Oct 24, 2023
src/App.tsx
Outdated
|
|
||
| export const App: React.FC = () => { | ||
| const [todos, setTodos] = useState<Todo[]>([]); | ||
| const [loading, setLoading] = useState(false); |
There was a problem hiding this comment.
Suggested change
| const [loading, setLoading] = useState(false); | |
| const [isLoading, setIsLoading] = useState(false); |
There was a problem hiding this comment.
src/App.tsx
Outdated
| const [loading, setLoading] = useState(false); | ||
| const [selectedTodo, setSelectedTodo] = useState<Todo | null>(null); | ||
| const [query, setQuery] = useState(''); | ||
| const [status, setStatus] = useState('all'); |
src/App.tsx
Outdated
Comment on lines
29
to
30
| (status === 'all' || (status === 'completed' && todo.completed) || (status === 'active' && !todo.completed)) | ||
| && todo.title.toLowerCase().includes(query.toLowerCase()) |
There was a problem hiding this comment.
could you simplify this expression
src/components/TodoList/TodoList.tsx
Outdated
Comment on lines
33
to
72
| <tr | ||
| data-cy="todo" | ||
| key={todo.id} | ||
| className={cn({ | ||
| 'has-background-info-light': selectedTodo === todo, | ||
| })} | ||
| > | ||
| <td className="is-vcentered">{todo.id}</td> | ||
| <td className="is-vcentered"> | ||
| {todo.completed && ( | ||
| <span className="icon" data-cy="iconCompleted"> | ||
| <i className="fas fa-check" /> | ||
| </span> | ||
| )} | ||
| </td> | ||
| <td className="is-vcentered is-expanded"> | ||
| <p | ||
| className={cn({ | ||
| 'has-text-success': todo.completed, | ||
| 'has-text-danger': !todo.completed, | ||
| })} | ||
| > | ||
| {todo.title} | ||
| </p> | ||
| </td> | ||
| <td className="has-text-right is-vcentered"> | ||
| <button | ||
| data-cy="selectButton" | ||
| className="button" | ||
| type="button" | ||
| onClick={() => onSelect(todo)} | ||
| > | ||
| <span className="icon"> | ||
| <i | ||
| className={cn('far', { | ||
| 'fa-eye-slash': selectedTodo === todo, | ||
| 'fa-eye': selectedTodo !== todo, | ||
| })} | ||
| /> | ||
| </span> |
There was a problem hiding this comment.
let's move this logic to the TodoItem component
| onClose = () => { }, | ||
| selectedTodo, | ||
| }) => { | ||
| const [loading, setLoading] = useState(false); |
There was a problem hiding this comment.
Suggested change
| const [loading, setLoading] = useState(false); | |
| const [isLoading, setIsLoading] = useState(false); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK