todos with api task implementation #1959
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlegPopovych
approved these changes
Oct 30, 2023
src/App.tsx
Outdated
| setVisibleTodos(filterTodos(todosFromServer, query, filter)); | ||
| }) | ||
| .finally(() => setLoading(false)); | ||
| }, [filter, query]); |
There was a problem hiding this comment.
It is not necessary to request to the server within every new symbol or filter change, in this case.
StasSokolov
suggested changes
Oct 31, 2023
| query, | ||
| }) => { | ||
| const handleFilterChange = (event: React.ChangeEvent<HTMLSelectElement>) => { | ||
| const newFilterBy = event.target.value as FilterBy; |
There was a problem hiding this comment.
it looks like this variable is redundant, using only one time
src/components/TodoList/TodoList.tsx
Outdated
| </tr> | ||
| <tr | ||
| data-cy="todo" | ||
| className="" |
Comment on lines
21
to
27
| useEffect(() => { | ||
| getUser(todoSelected.userId) | ||
| .then((givenUser) => { | ||
| setTodoUser(givenUser); | ||
| }) | ||
| .finally(() => setTodoLoading(false)); | ||
| }); |
There was a problem hiding this comment.
Suggested change
| useEffect(() => { | |
| getUser(todoSelected.userId) | |
| .then((givenUser) => { | |
| setTodoUser(givenUser); | |
| }) | |
| .finally(() => setTodoLoading(false)); | |
| }); | |
| useEffect(() => { | |
| getUser(todoSelected.userId) | |
| .then((givenUser) => { | |
| setTodoUser(givenUser); | |
| }) | |
| .finally(() => setTodoLoading(false)); | |
| }, []); |
let's add deps for useEffect because now useEffect will calling every time, please try to open modal and go to the network
look at requests
Comment on lines
60
to
66
| {todoSelected.completed | ||
| ? ( | ||
| <strong className="has-text-success">Done</strong> | ||
| ) | ||
| : ( | ||
| <strong className="has-text-danger">Planned</strong> | ||
| )} |
There was a problem hiding this comment.
we can use single strong tag and only change success to danger and children
StasSokolov
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo