Solution #2682
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,30 +1,59 @@ | ||
| import { Dispatch, SetStateAction } from 'react'; | ||
|
|
||
| import { SetStateCompletedStatus } from '../../types/SetStateCompletedStatus'; | ||
| import { CompletedStatus } from '../../types/CompletedStatus'; | ||
|
There was a problem hiding this comment. Ensure that the import |
||
|
|
||
| export const TodoFilter: React.FC<{ | ||
| query: string; | ||
| setQuery: Dispatch<SetStateAction<string>>; | ||
| setFilterStatus: SetStateCompletedStatus; | ||
| }> = ({ query, setQuery, setFilterStatus }) => { | ||
| function handleSearchChange(value: string) { | ||
| setQuery(value); | ||
| } | ||
|
|
||
| return ( | ||
| <form className="field has-addons"> | ||
| <p className="control"> | ||
| <span className="select"> | ||
| <select | ||
| onChange={event => | ||
| setFilterStatus(event.target.value as CompletedStatus) | ||
| } | ||
|
Comment on lines
+20
to
+21
There was a problem hiding this comment. Ensure that the value from |
||
| data-cy="statusSelect" | ||
| > | ||
| <option value={CompletedStatus.all}>All</option> | ||
| <option value={CompletedStatus.active}>Active</option> | ||
| <option value={CompletedStatus.completed}>Completed</option> | ||
| </select> | ||
| </span> | ||
| </p> | ||
|
|
||
| <p className="control is-expanded has-icons-left has-icons-right"> | ||
| <input | ||
| value={query} | ||
| onChange={event => handleSearchChange(event.target.value)} | ||
| data-cy="searchInput" | ||
| type="text" | ||
| className="input" | ||
| placeholder="Search..." | ||
| /> | ||
| <span className="icon is-left"> | ||
| <i className="fas fa-magnifying-glass" /> | ||
| </span> | ||
|
|
||
| {query && ( | ||
| <span className="icon is-right " style={{ pointerEvents: 'all' }}> | ||
| {/* eslint-disable-next-line jsx-a11y/control-has-associated-label */} | ||
|
There was a problem hiding this comment. Avoid inline styles, use classes instead |
||
| <button | ||
| onClick={() => handleSearchChange('')} | ||
| data-cy="clearSearchButton" | ||
| type="button" | ||
| className="delete" | ||
| /> | ||
| </span> | ||
| )} | ||
| </p> | ||
| </form> | ||
| ); | ||
| }; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,100 +1,81 @@ | ||||||
| import { Todo } from '../../types/Todo'; | ||||||
| import cN from 'classnames'; | ||||||
| import React from 'react'; | ||||||
| import { Dispatch, SetStateAction } from 'react'; | ||||||
|
|
||||||
| export const TodoList: React.FC<{ | ||||||
| todos: Todo[]; | ||||||
| selectedTodoId: number | null; | ||||||
| setSelectedTodoId: Dispatch<SetStateAction<number | null>>; | ||||||
| }> = ({ todos, selectedTodoId, setSelectedTodoId }) => { | ||||||
| return ( | ||||||
| <table className="table is-narrow is-fullwidth"> | ||||||
| <thead> | ||||||
| <tr> | ||||||
| <th>#</th> | ||||||
| <th> | ||||||
| <span className="icon"> | ||||||
| <i className="fas fa-check" /> | ||||||
| </span> | ||||||
| </th> | ||||||
| <th>Title</th> | ||||||
| <th> </th> | ||||||
| </tr> | ||||||
| </thead> | ||||||
| <tbody> | ||||||
| {todos.map((todo: Todo) => { | ||||||
| const { id, title, completed } = todo; | ||||||
|
|
||||||
| function onClickHandler() { | ||||||
|
There was a problem hiding this comment.
Suggested change
When you pass handler as a prop you should name it with |
||||||
| setSelectedTodoId(id); | ||||||
| } | ||||||
|
|
||||||
| return ( | ||||||
| <tr | ||||||
| key={id} | ||||||
| data-cy="todo" | ||||||
|
|
||||||
| className={cN({ | ||||||
| 'has-background-info-light': selectedTodoId === id, | ||||||
| })} | ||||||
| > | ||||||
| <td className="is-vcentered">{id}</td> | ||||||
| {completed ? ( | ||||||
| <td className="is-vcentered"> | ||||||
| <span className="icon" data-cy="iconCompleted"> | ||||||
| <i className="fas fa-check" /> | ||||||
| </span> | ||||||
| </td> | ||||||
| ) : ( | ||||||
| <td className="is-vcentered" /> | ||||||
| )} | ||||||
| <td className="is-vcentered is-expanded"> | ||||||
| <p | ||||||
| className={completed ? 'has-text-success' : 'has-text-danger'} | ||||||
| > | ||||||
| {title} | ||||||
| </p> | ||||||
| </td> | ||||||
| <td className="has-text-right is-vcentered"> | ||||||
| <button | ||||||
| onClick={onClickHandler} | ||||||
| data-cy="selectButton" | ||||||
| className="button" | ||||||
| type="button" | ||||||
| > | ||||||
| <span className="icon"> | ||||||
| <i | ||||||
| className={cN( | ||||||
| 'far', | ||||||
| selectedTodoId !== id ? 'fa-eye' : 'fa-eye-slash', | ||||||
|
There was a problem hiding this comment. You compare |
||||||
| )} | ||||||
| /> | ||||||
| </span> | ||||||
| </button> | ||||||
| </td> | ||||||
| </tr> | ||||||
| ); | ||||||
| })} | ||||||
| </tbody> | ||||||
| </table> | ||||||
| ); | ||||||
| }; | ||||||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Якщо ми вказуємо конкретне значення в useState, то можно явно не прописувати його тип, він визначиться автоматично, наприклад,
const [query, setQuery] = useState('');
Він сам визначає, що це буде рядок.
Але якщо ми в useState прописуємо null, то тоді дійсно треба визначити, який тип там має бути
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Хороша робота, вітаю тебе ))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point