Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #2722

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Develop #2722

wants to merge 4 commits into from

Conversation

stanishevskyy
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the task requirements! 🎉 The code is well-structured and meets most of the task constraints. Just make sure to verify that the TodoModal opens correctly when a todo is selected and that the Loader component is displayed properly while data is being fetched. These are crucial for ensuring full functionality. Keep up the good work and continue refining your skills! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

</div>

<div className="block">
<Loader />
<TodoList />
{loading && <Loader />}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the Loader component is displayed correctly while data is being fetched. This aligns with the task requirement to show the Loader when waiting for data from the server .

</div>
</div>
</div>
</div>

<TodoModal />
{todo && <TodoModal todo={todo} setTodo={setTodo} />}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verify that the TodoModal opens correctly when a todo is selected. This is crucial for meeting the task requirement of opening the TodoModal with a selected todo .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants