Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added logic for add form #1804

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ You have the `App` with the `MoviesList` and `NewMovie` form containing ready
to use `TextField` components. Learn how it works and implement an ability to
add movies from [IMDB](https://www.imdb.com/).

If you want to test your page you can get first image from a [movie page](https://www.imdb.com/title/tt1312171) using `DevTools` -> `Network` -> `Img`
If you want to test your page you can get first image from a [movie page](https://www.imdb.com/title/tt1312171) using `DevTools` -> `Network` -> `Img`

> Here is [the demo page](https://mate-academy.github.io/react_movies-list-add-form/)

Expand All @@ -30,4 +30,4 @@ const pattern = /^((([A-Za-z]{3,9}:(?:\/\/)?)(?:[-;:&=+$,\w]+@)?[A-Za-z0-9.-]+|(
- Implement a solution following the [React task guideline](https://github.com/mate-academy/react_task-guideline#react-tasks-guideline).
- Use the [React TypeScript cheat sheet](https://mate-academy.github.io/fe-program/js/extra/react-typescript).
- Open one more terminal and run tests with `npm test` to ensure your solution is correct.
- Replace `<your_account>` with your Github username in the [DEMO LINK](https://<your_account>.github.io/react_movies-list-add-form/) and add it to the PR description.
- Replace `<your_account>` with your Github username in the [DEMO LINK](https://irahos.github.io/react_movies-list-add-form/) and add it to the PR description.
12 changes: 10 additions & 2 deletions src/App.tsx
Original file line number Diff line number Diff line change
@@ -1,16 +1,24 @@
import './App.scss';
import { useState } from 'react';
import { MoviesList } from './components/MoviesList';
import { NewMovie } from './components/NewMovie';
import moviesFromServer from './api/movies.json';
import { Movie } from './types/Movie';

export const App = () => {
const [movies, setMovies] = useState<Movie[]>(moviesFromServer);

const onAddMovie = (movie: Movie) => {
setMovies((prevMovies) => [...prevMovies, movie]);
};

return (
<div className="page">
<div className="page-content">
<MoviesList movies={moviesFromServer} />
<MoviesList movies={movies} />
</div>
<div className="sidebar">
<NewMovie /* onAdd={(movie) => {}} */ />
<NewMovie onAdd={onAddMovie} />
</div>
</div>
);
Expand Down
143 changes: 89 additions & 54 deletions src/components/NewMovie/NewMovie.tsx
Original file line number Diff line number Diff line change
@@ -1,58 +1,93 @@
import { useState } from 'react';
import { TextField } from '../TextField';
import { Movie } from '../../types/Movie';

export const NewMovie = () => {
// Increase the count after successful form submission
// to reset touched status of all the `Field`s
const [count] = useState(0);

return (
<form className="NewMovie" key={count}>
<h2 className="title">Add a movie</h2>

<TextField
name="title"
label="Title"
value=""
onChange={() => {}}
required
/>

<TextField
name="description"
label="Description"
value=""
/>

<TextField
name="imgUrl"
label="Image URL"
value=""
/>

<TextField
name="imdbUrl"
label="Imdb URL"
value=""
/>

<TextField
name="imdbId"
label="Imdb ID"
value=""
/>

<div className="field is-grouped">
<div className="control">
<button
type="submit"
data-cy="submit-button"
className="button is-link"
>
Add
</button>
export const NewMovie
= ({ onAdd }: { onAdd: (movie: Movie) => void }) => {
const [count, setCount] = useState(0);
const [title, setTitle] = useState('');
const [description, setDescription] = useState('');
const [imgUrl, setImgUrl] = useState('');
const [imdbUrl, setImdbUrl] = useState('');
const [imdbId, setImdbId] = useState('');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All this should be kept in one state.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All this should be kept in one state.

You still have a state for each input, let's create one state for all of them. and one handler to update the state when onChange event is triggered.

Your default state can looks like:

const deafultFormState = {
  title: '',
  description: '',
  imgUrl: '',
  imdbUrl: '',
  imdbId: '',
}


const formReset = () => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function name must begin with a verb.

Suggested change
const formReset = () => {
const resetForm = () => {

setTitle('');
setDescription('');
setImgUrl('');
setImdbUrl('');
setImdbId('');
};

const isDisabled = () => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const isDisabled = () => {
const isAddButtonDisabled = () => {

return !(title && imgUrl && imdbUrl && imdbId);
};

const submit = (): void => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const submit = (): void => {
const handleSubmit = (): void => {

onAdd({
title, description, imgUrl, imdbUrl, imdbId,
});

formReset();

setCount((prevCount) => prevCount + 1);
};

return (
<form className="NewMovie" key={count} onSubmit={submit}>
<h2 className="title">Add a movie</h2>

<TextField
name="title"
label="Title"
value={title}
onChange={setTitle}
required
/>

<TextField
name="description"
label="Description"
onChange={setDescription}
value={description}
/>

<TextField
name="imgUrl"
label="Image URL"
value={imgUrl}
onChange={setImgUrl}
required
/>

<TextField
name="imdbUrl"
label="Imdb URL"
value={imdbUrl}
onChange={setImdbUrl}
required
/>

<TextField
name="imdbId"
label="Imdb ID"
value={imdbId}
onChange={setImdbId}
required
/>

<div className="field is-grouped">
<div className="control">
<button
type="submit"
data-cy="submit-button"
className="button is-link"
disabled={isDisabled()}
>
Add
</button>
</div>
</div>
</div>
</form>
);
};
</form>
);
};
2 changes: 0 additions & 2 deletions src/components/TextField/TextField.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,8 @@ export const TextField: React.FC<Props> = ({
required = false,
onChange = () => {},
}) => {
// generage a unique id once on component load
const [id] = useState(() => `${name}-${getRandomDigits()}`);

// To show errors only if the field was touched (onBlur)
const [touched, setTouched] = useState(false);
const hasError = touched && required && !value;

Expand Down