react_movies-list-add-form #1873
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanFesenko
suggested changes
Sep 26, 2023
There was a problem hiding this comment.
Only spaces is not valid inputs, add url validation
https://github.com/mate-academy/react_movies-list-add-form/assets/61904995/0c168339-dc89-4038-81a6-40a15fa1ac2b
src/components/NewMovie/NewMovie.tsx
Outdated
Comment on lines
12
to
16
| const [nameValue, setNameValue] = useState(''); | ||
| const [descriptionValue, setDescriptionValue] = useState(''); | ||
| const [img, setImg] = useState(''); | ||
| const [imdbUrlValue, setImdbUrlValue] = useState(''); | ||
| const [imdbIdValue, setImdbIdValue] = useState(''); |
There was a problem hiding this comment.
Lets combine it into one state intead of 5
const [movie, setMovie] = useState({
title: '',
description: '',
....
});
anastasiiavorobiova
suggested changes
Oct 1, 2023
src/App.tsx
Outdated
|
|
||
| export const App = () => { | ||
| const [moviesServer, setMoviesServer] = useState<Movie[]>(moviesFromServer); | ||
| const onAdd = (newmovie:Movie) => { | ||
| setMoviesServer([...moviesServer, newmovie]); |
There was a problem hiding this comment.
Suggested change
| setMoviesServer([...moviesServer, newmovie]); | |
| setMoviesServer((moviesServer) => [...moviesServer, newmovie]); |
Consider using a callback here to avoid bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://OlegRak86.github.io/react_movies-list-add-form/