Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

movies list add form v1 #1889

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ You have the `App` with the `MoviesList` and `NewMovie` form containing ready
to use `TextField` components. Learn how it works and implement an ability to
add movies from [IMDB](https://www.imdb.com/).

If you want to test your page you can get first image from a [movie page](https://www.imdb.com/title/tt1312171) using `DevTools` -> `Network` -> `Img`
If you want to test your page you can get first image from a [movie page](https://www.imdb.com/title/tt1312171) using `DevTools` -> `Network` -> `Img`

> Here is [the demo page](https://mate-academy.github.io/react_movies-list-add-form/)

Expand All @@ -30,4 +30,4 @@ const pattern = /^((([A-Za-z]{3,9}:(?:\/\/)?)(?:[-;:&=+$,\w]+@)?[A-Za-z0-9.-]+|(
- Implement a solution following the [React task guideline](https://github.com/mate-academy/react_task-guideline#react-tasks-guideline).
- Use the [React TypeScript cheat sheet](https://mate-academy.github.io/fe-program/js/extra/react-typescript).
- Open one more terminal and run tests with `npm test` to ensure your solution is correct.
- Replace `<your_account>` with your Github username in the [DEMO LINK](https://<your_account>.github.io/react_movies-list-add-form/) and add it to the PR description.
- Replace `<your_account>` with your Github username in the [DEMO LINK](https://oltarasov.github.io/react_movies-list-add-form/) and add it to the PR description.
19 changes: 17 additions & 2 deletions src/App.tsx
Original file line number Diff line number Diff line change
@@ -1,16 +1,31 @@
import './App.scss';
import { useState } from 'react';
import { MoviesList } from './components/MoviesList';
import { NewMovie } from './components/NewMovie';
import moviesFromServer from './api/movies.json';

type Movie = {
title: string;
description: string;
imgUrl: string;
imdbUrl: string;
imdbId: string;
};

export const App = () => {
const [movies, setMovies] = useState([...moviesFromServer]);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what this spread operator, react created new array each render, and first value it's just default value which don't change moviesFromServer variable


const addNewMovie = (movie: Movie) => {
setMovies(prevState => [...prevState, movie]);
};

return (
<div className="page">
<div className="page-content">
<MoviesList movies={moviesFromServer} />
<MoviesList movies={movies} />
</div>
<div className="sidebar">
<NewMovie /* onAdd={(movie) => {}} */ />
<NewMovie onAdd={addNewMovie} />
</div>
</div>
);
Expand Down
67 changes: 57 additions & 10 deletions src/components/NewMovie/NewMovie.tsx
Original file line number Diff line number Diff line change
@@ -1,45 +1,91 @@
import { useState } from 'react';
import React, { useState } from 'react';
import { TextField } from '../TextField';
import { Movie } from '../../types/Movie';

export const NewMovie = () => {
type Props = {
onAdd: (movie: Movie) => void
};

export const NewMovie: React.FC<Props> = ({ onAdd }) => {
// Increase the count after successful form submission
// to reset touched status of all the `Field`s
const [count] = useState(0);

const [count, setCount] = useState(0);
const [title, setTitle] = useState('');
const [description, setDescription] = useState('');
const [imgUrl, setImgUrl] = useState('');
const [imdbUrl, setImdbUrl] = useState('');
const [imdbId, setImdbId] = useState('');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Combine it into 1 state { title, description, ..... }


const readyToSubmit = [title, imgUrl, imdbUrl, imdbId]
.every(item => item !== '');

const handleSubmit = (event: React.FormEvent) => {
event.preventDefault();
setCount(prevState => prevState + 1);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before adding a movie you should validate values. Right now I can just press space for all form fields and submit a form

onAdd({
title: title.trim(),
description: description.trim(),
imdbId: imdbId.trim(),
imdbUrl: imdbUrl.trim(),
imgUrl: imgUrl.trim(),
});

[setTitle, setDescription, setImgUrl, setImdbUrl, setImdbId]
.forEach(func => func(''));
};

return (
<form className="NewMovie" key={count}>
<form className="NewMovie" key={count} onSubmit={handleSubmit}>
<h2 className="title">Add a movie</h2>

<TextField
name="title"
label="Title"
value=""
onChange={() => {}}
value={title.trim()}
onChange={(value) => {
setTitle(value);
}}
required
/>

<TextField
name="description"
label="Description"
value=""
value={description}
onChange={(value) => {
setDescription(value);
}}
/>

<TextField
name="imgUrl"
label="Image URL"
value=""
value={imgUrl}
onChange={(value) => {
setImgUrl(value);
}}
required
/>

<TextField
name="imdbUrl"
label="Imdb URL"
value=""
value={imdbUrl}
onChange={(value) => {
setImdbUrl(value);
}}
required
/>

<TextField
name="imdbId"
label="Imdb ID"
value=""
value={imdbId}
onChange={(value) => {
setImdbId(value);
}}
/>

<div className="field is-grouped">
Expand All @@ -48,6 +94,7 @@ export const NewMovie = () => {
type="submit"
data-cy="submit-button"
className="button is-link"
disabled={!readyToSubmit}
>
Add
</button>
Expand Down
1 change: 1 addition & 0 deletions src/components/TextField/TextField.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import classNames from 'classnames';
import React, { useState } from 'react';
// import { Movie } from '../../types/Movie';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove comment


type Props = {
name: string,
Expand Down