solution #1892
Open
solution #1892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sTorba24
suggested changes
Oct 12, 2023
src/components/NewMovie/NewMovie.tsx
Outdated
Comment on lines
61
to
65
| const isDisabled = !(title.trim() | ||
| && imgUrl.trim() | ||
| && imdbUrl.trim() | ||
| && imdbId.trim() | ||
| ); |
etojeDenys
suggested changes
Oct 17, 2023
src/components/NewMovie/NewMovie.tsx
Outdated
Comment on lines
10
to
14
| const [title, setTitle] = useState(''); | ||
| const [description, setDescription] = useState(''); | ||
| const [imgUrl, setImgUrl] = useState(''); | ||
| const [imdbUrl, setImdbUrl] = useState(''); | ||
| const [imdbId, setImdbId] = useState(''); |
There was a problem hiding this comment.
we can combine it in one useState
const [newMovie, setNewMovie] = useState({
title: '',
...
})
now we can also create only one handle function for all fields
const handleChange = (e: ...) => {
const {name, value} = e.target;
setMovie((prevMovie) => ({...prevMovie, [name]: value}))
}
don't forget to specify name attr to input in TextField
etojeDenys
approved these changes
Oct 20, 2023
| id={id} | ||
| data-cy={`movie-${name}`} | ||
| className={classNames('input', { | ||
| 'is-danger': hasError, | ||
| })} | ||
| placeholder={placeholder} | ||
| value={value} | ||
| onChange={event => onChange(event.target.value)} | ||
| onChange={event => onChange(event)} |
There was a problem hiding this comment.
Suggested change
| onChange={event => onChange(event)} | |
| onChange={onChange} |
we can simplify it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK