Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task solution #1895

Closed
wants to merge 2 commits into from
Closed

task solution #1895

wants to merge 2 commits into from

Conversation

pr1syazhniy
Copy link

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Comment on lines 32 to 38
onAdd({
title: movie.title,
description: movie.description,
imgUrl: movie.imgUrl,
imdbUrl: movie.imdbUrl,
imdbId: movie.imdbId,
});

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
onAdd({
title: movie.title,
description: movie.description,
imgUrl: movie.imgUrl,
imdbUrl: movie.imdbUrl,
imdbId: movie.imdbId,
});
onAdd(movie);

Copy link

@maxim2310 maxim2310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, but lets make some improvement
would be nice to add validation to url inputs

@pr1syazhniy pr1syazhniy closed this by deleting the head repository Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants