made add form for movie list #1908
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivaZaiets
approved these changes
Oct 19, 2023
polosanya
suggested changes
Oct 20, 2023
src/components/NewMovie/NewMovie.tsx
Outdated
Comment on lines
14
to
20
| // #region state | ||
| const [title, setTitle] = useState(''); | ||
| const [description, setDescription] = useState(''); | ||
| const [imgUrl, setImgUrl] = useState(''); | ||
| const [imdbUrl, setImdbUrl] = useState(''); | ||
| const [imdbId, setImdbId] = useState(''); | ||
| // #endregion |
There was a problem hiding this comment.
Region comments are actually redundant here but it's up to you
src/components/NewMovie/NewMovie.tsx
Outdated
Comment on lines
39
to
43
| setTitle(''); | ||
| setDescription(''); | ||
| setImgUrl(''); | ||
| setImdbUrl(''); | ||
| setImdbId(''); |
There was a problem hiding this comment.
Would be great to create a separate function for resetting
src/components/NewMovie/NewMovie.tsx
Outdated
Comment on lines
60
to
62
| onChange={(value: string): void => { | ||
| setTitle(value); | ||
| }} |
There was a problem hiding this comment.
Suggested change
| onChange={(value: string): void => { | |
| setTitle(value); | |
| }} | |
| onChange={setTitle} |
Can be simplified a lot. Fix all cases
StasSokolov1
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK