branch in development (uploading to check tests) #1920
Conversation
| <NewMovie onAdd={(movie) => { | ||
| addMovie(movie); | ||
| }} |
There was a problem hiding this comment.
| <NewMovie onAdd={(movie) => { | |
| addMovie(movie); | |
| }} | |
| <NewMovie onAdd={addMovie} |
can be simplify
There was a problem hiding this comment.
I don't think this is valid as we need to Recieve a movie value from a prop.
Writing it your way will make it hard to recieve the Object with info about movie from the component NewMovie
src/components/NewMovie/NewMovie.tsx
Outdated
| }; | ||
|
|
||
| const disabledCondition | ||
| = titleValue === '' |
There was a problem hiding this comment.
| = titleValue === '' | |
| = !titleValue |
can be simplify, check please below also
| }; | ||
|
|
||
| const reset = () => { | ||
| setCount(count + 1); |
There was a problem hiding this comment.
is this correct? when user click reset button the count is increase? i think should be initial value
There was a problem hiding this comment.
// Increase the count after successful form submission
// to reset touched status of all the Fields
Yes, the comment in Master branch requests this to for reset
There was a problem hiding this comment.
Also, there is no reset button. Reset is done on the press of submit to clear the fields, which also ticks up count to prevent error message from appearing.
| onAdd(movie); | ||
| reset(); |
There was a problem hiding this comment.
in this place when user click add button the count should be increase
There was a problem hiding this comment.
And it does in the Reset function
|
The |
DEMO LINK
Please be aware that this is an unfinished version. As the command 'npm test' always times out, I'm making this pull request to check tests and see what I need to improve. However, feel free to add feedback if you wish.
Update: Tests were successful!