Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react_movies-list-add-form solution #1949

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

react_movies-list-add-form solution #1949

wants to merge 3 commits into from

Conversation

Medaed
Copy link

@Medaed Medaed commented Oct 30, 2023

nazarmatsevych
nazarmatsevych suggested changes Oct 30, 2023
View reviewed changes
Copy link

@nazarmatsevych nazarmatsevych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add movie with empty fields, use trim() method to fix it:
image

@Medaed Medaed requested a review from nazarmatsevych November 1, 2023 13:32
anastasiiavorobiova
anastasiiavorobiova suggested changes Nov 1, 2023
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Consider fixing the process of adding a movie with a space between words

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanyaBratashchuk SanyaBratashchuk SanyaBratashchuk approved these changes

@nazarmatsevych nazarmatsevych Awaiting requested review from nazarmatsevych

@anastasiiavorobiova anastasiiavorobiova Awaiting requested review from anastasiiavorobiova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Medaed @nazarmatsevych @SanyaBratashchuk @anastasiiavorobiova