Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task solution #2654

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

task solution #2654

wants to merge 3 commits into from

Conversation

AsyaDev14
Copy link

Copy link

@so3r so3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, great job) You can only delete unnecessary comments

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

There are no files to review. Please make sure that you have added files to the pull request. Some files and directories may be ignored from the review or failed to load.
[CODE: 4]

Additional info:
Ignored files list:

  • src/App.tsx
  • src/components/NewMovie/NewMovie.tsx
  • src/components/TextField/TextField.tsx

If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.

Copy link

@StasSokolov1 StasSokolov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done, let's improve your code a bit more🔥

src/App.tsx Outdated Show resolved Hide resolved
src/App.tsx Outdated Show resolved Hide resolved
src/components/NewMovie/NewMovie.tsx Outdated Show resolved Hide resolved
src/components/NewMovie/NewMovie.tsx Outdated Show resolved Hide resolved
src/components/NewMovie/NewMovie.tsx Outdated Show resolved Hide resolved
src/components/NewMovie/NewMovie.tsx Outdated Show resolved Hide resolved
Copy link

@Moroz-Dmytro Moroz-Dmytro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting solution 🔥
But fix some comments below

src/App.tsx Outdated Show resolved Hide resolved
src/components/NewMovie/NewMovie.tsx Outdated Show resolved Hide resolved
src/components/NewMovie/NewMovie.tsx Outdated Show resolved Hide resolved
src/components/NewMovie/NewMovie.tsx Outdated Show resolved Hide resolved
Copy link

@Moroz-Dmytro Moroz-Dmytro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, approve it 🚀
But check comments below

Comment on lines +63 to +65
onSubmit={(event: React.FormEvent<HTMLFormElement>): void =>
handleSubmit(event)
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
onSubmit={(event: React.FormEvent<HTMLFormElement>): void =>
handleSubmit(event)
}
onSubmit={handleSubmit}

Comment on lines +68 to +79
{formInputs.map(item => {
return (
<TextField
key={item.name}
name={item.name}
label={item.label}
value={item.value}
onChange={item.onChange}
required={item.required}
/>
);
})}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{formInputs.map(item => {
return (
<TextField
key={item.name}
name={item.name}
label={item.label}
value={item.value}
onChange={item.onChange}
required={item.required}
/>
);
})}
{formInputs.map(item => (
<TextField
key={item.name}
{...item}
/>
))}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants