solution #2657
solution #2657
Conversation
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
There are no files to review. Please make sure that you have added files to the pull request. Some files and directories may be ignored from the review or failed to load.
[CODE: 4]
Additional info:
Ignored files list:
src/App.tsxsrc/components/NewMovie/NewMovie.tsx
If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
There are no files to review. Please make sure that you have added files to the pull request. Some files and directories may be ignored from the review or failed to load.
[CODE: 4]
Additional info:
Ignored files list:
src/App.tsxsrc/components/NewMovie/NewMovie.tsx
If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
There are no files to review. Please make sure that you have added files to the pull request. Some files and directories may be ignored from the review or failed to load.
[CODE: 4]
Additional info:
Ignored files list:
src/App.tsxsrc/components/NewMovie/NewMovie.tsx
If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
There are no files to review. Please make sure that you have added files to the pull request. Some files and directories may be ignored from the review or failed to load.
[CODE: 4]
Additional info:
Ignored files list:
src/App.tsxsrc/components/NewMovie/NewMovie.tsx
If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.
src/components/NewMovie/NewMovie.tsx
Outdated
| const areAllQueries: boolean = | ||
| title.trim() !== '' && |
There was a problem hiding this comment.
| const areAllQueries: boolean = | |
| title.trim() !== '' && | |
| const areAllQueries = | |
| Boolean(title.trim() && // other checks |
You don't need to specify type every time, typescript can do it for you. And you don't have
src/components/NewMovie/NewMovie.tsx
Outdated
| // to reset touched status of all the `Field`s | ||
| const [count] = useState(0); | ||
| interface NewMovieProps { | ||
| onAdd?: (movie: Movie) => void; |
There was a problem hiding this comment.
| onAdd?: (movie: Movie) => void; | |
| onAdd: (movie: Movie) => void; |
Do it requred
src/components/NewMovie/NewMovie.tsx
Outdated
| value="" | ||
| onChange={() => {}} | ||
| value={title} | ||
| onChange={(e: string) => setTitle(e)} |
There was a problem hiding this comment.
| onChange={(e: string) => setTitle(e)} | |
| onChange={setTitle} |
Could be simplified
Fix in all places
DEMO LINK